From 1d85a000e26466ff357a98e9b21147f35c801fd0 Mon Sep 17 00:00:00 2001 From: hathach Date: Tue, 14 Dec 2021 15:36:14 +0700 Subject: [PATCH 1/3] use softprops/action-gh-release@v1 --- .github/workflows/githubci.yml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/githubci.yml b/.github/workflows/githubci.yml index 44da069..c0af9fc 100644 --- a/.github/workflows/githubci.yml +++ b/.github/workflows/githubci.yml @@ -24,7 +24,7 @@ jobs: - 'itsybitsy_nrf52840_express' - 'metro_nrf52840_express' - 'ledglasses_nrf52840' - # Alphabetical order + # Other Makers (Alphabetical order) - 'adm_b_nrf52840_1' - 'ae_bl652_bo' - 'aramcon_badge_2019' @@ -111,7 +111,7 @@ jobs: asset_name: ${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}.zip asset_content_type: application/zip - - name: Upload Release Asset for Self-Update + - name: Release Asset for UF2 uses: actions/upload-release-asset@v1 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -121,3 +121,11 @@ jobs: asset_path: _bin/${{ matrix.board }}/update-${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}_nosd.uf2 asset_name: update-${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}_nosd.uf2 asset_content_type: application/x-binary + + - name: Release Asset + uses: softprops/action-gh-release@v1 + if: ${{ github.event_name == 'release' }} + with: + files: | + _bin/${{ matrix.board }}/${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}_s140_6.1.1.zip + _bin/${{ matrix.board }}/${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}_s140_6.1.1.hex From 68959e00c4d675dc3183206c566d781353beaf07 Mon Sep 17 00:00:00 2001 From: hathach Date: Tue, 14 Dec 2021 15:41:17 +0700 Subject: [PATCH 2/3] try wildcard for release assest filename --- .github/workflows/githubci.yml | 31 +++---------------------------- 1 file changed, 3 insertions(+), 28 deletions(-) diff --git a/.github/workflows/githubci.yml b/.github/workflows/githubci.yml index c0af9fc..f4264b7 100644 --- a/.github/workflows/githubci.yml +++ b/.github/workflows/githubci.yml @@ -96,36 +96,11 @@ jobs: name: ${{ matrix.board }} path: _bin/${{ matrix.board }} - - name: Create Release Asset - if: ${{ github.event_name == 'release' }} - run: zip -jr ${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}.zip _bin/${{ matrix.board }} - - name: Upload Release Asset - uses: actions/upload-release-asset@v1 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - if: ${{ github.event_name == 'release' }} - with: - upload_url: ${{ github.event.release.upload_url }} - asset_path: ${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}.zip - asset_name: ${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}.zip - asset_content_type: application/zip - - - name: Release Asset for UF2 - uses: actions/upload-release-asset@v1 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - if: ${{ github.event_name == 'release' }} - with: - upload_url: ${{ github.event.release.upload_url }} - asset_path: _bin/${{ matrix.board }}/update-${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}_nosd.uf2 - asset_name: update-${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}_nosd.uf2 - asset_content_type: application/x-binary - - - name: Release Asset uses: softprops/action-gh-release@v1 if: ${{ github.event_name == 'release' }} with: files: | - _bin/${{ matrix.board }}/${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}_s140_6.1.1.zip - _bin/${{ matrix.board }}/${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}_s140_6.1.1.hex + _bin/${{ matrix.board }}/${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}*.zip + _bin/${{ matrix.board }}/${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}*.hex + _bin/${{ matrix.board }}/update-${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}_nosd.uf2 From f6c96149767e7968ff45f73eb37d0845ab6cfdae Mon Sep 17 00:00:00 2001 From: hathach Date: Tue, 14 Dec 2021 16:13:14 +0700 Subject: [PATCH 3/3] more clean up --- .github/workflows/githubci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/githubci.yml b/.github/workflows/githubci.yml index f4264b7..bfc1461 100644 --- a/.github/workflows/githubci.yml +++ b/.github/workflows/githubci.yml @@ -101,6 +101,6 @@ jobs: if: ${{ github.event_name == 'release' }} with: files: | - _bin/${{ matrix.board }}/${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}*.zip - _bin/${{ matrix.board }}/${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}*.hex - _bin/${{ matrix.board }}/update-${{ matrix.board }}_bootloader-${{ github.event.release.tag_name }}_nosd.uf2 + _bin/${{ matrix.board }}/${{ matrix.board }}_bootloader-*.zip + _bin/${{ matrix.board }}/${{ matrix.board }}_bootloader-*.hex + _bin/${{ matrix.board }}/update-${{ matrix.board }}_bootloader-*.uf2