This is a pretty bold piece of work and it's a shame to remove it for
now.
We would like to bring it back, possibly as a protection.
However, there isn't the time while we move over to the new MPS backend.
Much like the joins command, this needs rewriting to use
`SetMembership` from MPS and there isn't the time to do that
right now.
These commands didn't seem to work as intended anyway.
In reality this sets a default shortcode,
and for the moment we aren't able to work with shortcodes.
I don't know if it makes sense to bring this command back
in future because we would like to instead have
the ban propagation protection have a setting
for a list to fill client bans directly into.
This should be managed from the client, and the idea
that being a Synapse admin makes a difference is unfounded.
It wasn't even connected to the command handler anyway.
This stores create database files all over the cwd that use nedb
which shouldn't really be used by the appservice library at this
point.
These files are problematic because they are undocumented to
server admins trying to setup the appservice, and need to be
explicitly accounted for to make permissions work.
The stores enable something called the `BridgeContext` to be
given alongside the event within the `onEvent` handler.
Which we don't use, and it's unclear how it should be used.
The primary motivation for removing the stores is to simplify
work making the appservice available to matrix-docker-ansible-deploy.
We expect to have follow up prs to improve documentation.
This provides two new arguments for paths to load secretes for `--access-token-path` and `--pantalaimon-password-path` from.
The intention being that they can be used with a credentials system such as https://systemd.io/CREDENTIALS/.
They will take precedence over anything within the config file.
Suggested after https://github.com/NixOS/nixpkgs/pull/274052#discussion_r1481633083.
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add support for bot-sdk crypto as an experimental flag
* Import and use StoreType enum
* Fail hard instead of continuing in case of having pantalaimon and bot-sdk set up
* Document Option in default.yaml
* Remove obsolete comment
We were clearly in the process of deleting the
member decleration to just have the decleration be in the constructor.
When we were distracted, leaving a property named `readonly`, which
shouldn't be possible imo, need to add some rule for that prompto.
Before CommandError's where and they are used
liberally for validating command arguments by
returning a CommandResult for several possible
options. Which gives a lot of spam. It's not necessary
anyways since these should only be used for known errors.
Shouldn't change what is being logged to the log file,
but it does change what gets sent to the management room.
I've been meaning to disable this for some time as it generally
confuses new users and it makes the bot feel very confusing and
low quality. It also means you are likely to miss more important
messages in the magement room.
Another problem it causes is an inconsistent view when testing
the software and it's an unreasonable burden to test for both
settings.
It's not clear what the value of this setting is apart from
providing comfort to some users who want to see the ACL readout.
But even then it's a very inefficient way of doing that,
so i'd rather another feature be requested by users that want to see that.
gnuxie