mirror of
https://github.com/the-draupnir-project/Draupnir.git
synced 2026-05-14 19:35:14 +00:00
60eeb86415
Docker Hub - Develop / docker-latest (push) Failing after 31s
Tests / Build & Lint (push) Failing after 2m39s
Tests / Unit tests (push) Successful in 2m52s
Tests / Integration tests (push) Failing after 16s
Tests / Application Service Integration tests (push) Failing after 16s
GHCR - Development Branches / ghcr-publish (push) Failing after 12m26s
* Tighten ActionException wrapping to only accept Error. For months we had a bug where the "exception kind" enum was being provided as the error instead of the wrapped error in bot sdk wrapper code. This exception kind enum was optional in the factory method being used for the MatrixException type and so this resulted in draupnir reporting simply `undefined` when there were errors. Which was a major issue because not only did it make it difficult to track problems down, but it made the software look like shit. Remarkably we were still able to remotely diagnose problems essentially blind here. But it was caused by the ActionException accepting `unknown` for Error in order to tolerate a number of causes. We figure that this is unacceptable because it allows for these kinds of bugs and also that it delays finding out where we are calling broken apis. Closes https://github.com/the-draupnir-project/Draupnir/issues/759. Closes https://github.com/the-draupnir-project/planning/issues/137. * Flakey test idk.