mirror of
https://github.com/mikecarper/MeshCore.git
synced 2026-09-26 16:27:57 +00:00
agessaman
da6406e92f
The hostname was built once in begin() from the node name, so `set name` left the node advertising its old name to DHCP until the next reflash. It is now rebuilt on rename through a new CommonCLICallbacks::onNodeNameChanged() hook, and begin() shares the same helper. What this cannot do is rename a live lease. IDF 4.4 states that a hostname changed after the interface is up "would only be reflected once the interface restarts/reconnects", and Arduino 2.x's WiFi.setHostname() does not touch a running netif at all — it writes a static string that the netif reads at bring-up. Forcing the issue would mean bouncing the link, which costs every MQTT slot a reconnect; that is not a reasonable price for a rename, so the new name lands at the next reconnect or boot instead. Only automatic (Ethernet-preferred) links carry a hostname today, exactly as before. Giving plain Wi-Fi observers one would change the DHCP identity of the existing fleet and is a separate decision.