From 0b9245830b7292559f591130ec355bf13bbe0c4e Mon Sep 17 00:00:00 2001 From: Ivan Date: Sun, 19 Apr 2026 11:35:43 -0500 Subject: [PATCH] refactor(tests): clean up test code by removing unnecessary line breaks and improving formatting for better readability --- tests/frontend/RNodeDiagnostics.test.js | 11 ++++------- tests/frontend/RNodeFlasherPage.test.js | 15 ++++----------- tests/frontend/RNodeTransports.test.js | 8 +++++--- tests/frontend/StickerView.test.js | 4 +--- .../mediaLottieStickerGifs.fuzzing.test.js | 1 - 5 files changed, 14 insertions(+), 25 deletions(-) diff --git a/tests/frontend/RNodeDiagnostics.test.js b/tests/frontend/RNodeDiagnostics.test.js index 4915248..4575b47 100644 --- a/tests/frontend/RNodeDiagnostics.test.js +++ b/tests/frontend/RNodeDiagnostics.test.js @@ -47,14 +47,11 @@ describe("Diagnostics.diagnose", () => { }); it("flags not_provisioned when rom.parse returns falsy", async () => { - const result = await diagnose( - fakeRnode({ getRomAsObject: async () => ({ eeprom: [], parse: () => null }) }), - { timeoutMs: 1000 } - ); + const result = await diagnose(fakeRnode({ getRomAsObject: async () => ({ eeprom: [], parse: () => null }) }), { + timeoutMs: 1000, + }); expect(result.issues).toContain(ISSUE_NOT_PROVISIONED); - expect(result.suggestionKeys).toContain( - "tools.rnode_flasher.diagnostics.suggestions.not_provisioned" - ); + expect(result.suggestionKeys).toContain("tools.rnode_flasher.diagnostics.suggestions.not_provisioned"); }); it("flags firmware_hash_missing when target hash is all zero or missing", async () => { diff --git a/tests/frontend/RNodeFlasherPage.test.js b/tests/frontend/RNodeFlasherPage.test.js index 8d342ca..4fcc9d1 100644 --- a/tests/frontend/RNodeFlasherPage.test.js +++ b/tests/frontend/RNodeFlasherPage.test.js @@ -12,9 +12,7 @@ describe("RNodeFlasherPage.vue", () => { json: () => Promise.resolve({ tag_name: "v1.0", - assets: [ - { name: "firmware.zip", browser_download_url: "http://example.com/firmware.zip" }, - ], + assets: [{ name: "firmware.zip", browser_download_url: "http://example.com/firmware.zip" }], }), }); } @@ -56,9 +54,7 @@ describe("RNodeFlasherPage.vue", () => { const wrapper = mountRNodeFlasherPage(); expect(wrapper.vm.showAdvanced).toBe(false); - const advancedButton = wrapper - .findAll("button") - .find((b) => b.text().includes("tools.rnode_flasher.advanced")); + const advancedButton = wrapper.findAll("button").find((b) => b.text().includes("tools.rnode_flasher.advanced")); await advancedButton.trigger("click"); expect(wrapper.vm.showAdvanced).toBe(true); @@ -68,8 +64,7 @@ describe("RNodeFlasherPage.vue", () => { it("switches connection method", async () => { const wrapper = mountRNodeFlasherPage(); - const wifiButton = wrapper - .findAll('[data-testid="rnode-transport-wifi"]')[0]; + const wifiButton = wrapper.findAll('[data-testid="rnode-transport-wifi"]')[0]; await wifiButton.trigger("click"); expect(wrapper.vm.connectionMethod).toBe("wifi"); @@ -97,8 +92,6 @@ describe("RNodeFlasherPage.vue", () => { wrapper.vm.selectedProduct = { firmware_filename: "rnode_firmware_heltec32v3.zip" }; wrapper.vm.latestRelease = null; const url = wrapper.vm._resolveRecommendedAssetUrl(); - expect(url).toMatch( - /\/Reticulum\/RNode_Firmware\/releases\/latest\/download\/rnode_firmware_heltec32v3\.zip$/ - ); + expect(url).toMatch(/\/Reticulum\/RNode_Firmware\/releases\/latest\/download\/rnode_firmware_heltec32v3\.zip$/); }); }); diff --git a/tests/frontend/RNodeTransports.test.js b/tests/frontend/RNodeTransports.test.js index 920a96a..6eddcc4 100644 --- a/tests/frontend/RNodeTransports.test.js +++ b/tests/frontend/RNodeTransports.test.js @@ -19,9 +19,11 @@ describe("SerialTransport.request", () => { const env = { navigator: { serial: { - requestPort: vi.fn().mockRejectedValue( - Object.assign(new Error("No port selected by the user."), { name: "NotFoundError" }) - ), + requestPort: vi + .fn() + .mockRejectedValue( + Object.assign(new Error("No port selected by the user."), { name: "NotFoundError" }) + ), }, }, }; diff --git a/tests/frontend/StickerView.test.js b/tests/frontend/StickerView.test.js index 54e918f..869cd91 100644 --- a/tests/frontend/StickerView.test.js +++ b/tests/frontend/StickerView.test.js @@ -58,9 +58,7 @@ describe("StickerView.vue", () => { it("TGS renders placeholder without fetching sticker URL", async () => { const baseFetch = globalThis.fetch; - const fetchSpy = vi.spyOn(globalThis, "fetch").mockImplementation((input, init) => - baseFetch(input, init) - ); + const fetchSpy = vi.spyOn(globalThis, "fetch").mockImplementation((input, init) => baseFetch(input, init)); const w = mount(StickerView, { props: { diff --git a/tests/frontend/mediaLottieStickerGifs.fuzzing.test.js b/tests/frontend/mediaLottieStickerGifs.fuzzing.test.js index ecd1ba9..11f4d50 100644 --- a/tests/frontend/mediaLottieStickerGifs.fuzzing.test.js +++ b/tests/frontend/mediaLottieStickerGifs.fuzzing.test.js @@ -88,5 +88,4 @@ describe("fuzzing: TGS decode", () => { } expect(true).toBe(true); }); - });