From f1390afa718f52d8878970287fcbfa4a00b050d7 Mon Sep 17 00:00:00 2001 From: agessaman Date: Sun, 19 Jul 2026 15:14:26 -0700 Subject: [PATCH] ci(beta): drop self-referencing env redeclarations The build step redeclared OTA_MANIFEST_BASE_URL and OTA_CHANNEL_TAG as ${{ env.X }}, referencing the very variables it was setting. Workflow-level env: is already inherited by every step, so this was redundant; had the self-reference resolved empty it would have silently blanked the channel and produced firmware with no manifest base. The verify step would have caught it, but the risk is unnecessary. --- .github/workflows/build-observer-firmwares-beta.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-observer-firmwares-beta.yml b/.github/workflows/build-observer-firmwares-beta.yml index 4ea08206..4a7c02d8 100644 --- a/.github/workflows/build-observer-firmwares-beta.yml +++ b/.github/workflows/build-observer-firmwares-beta.yml @@ -150,9 +150,10 @@ jobs: - name: Build Shard ${{ matrix.shard.idx }} env: FIRMWARE_BUILD_NUMBER: ${{ needs.enumerate.outputs.build_number }} - # These two are what make the output a beta build; build.sh reads both. - OTA_MANIFEST_BASE_URL: ${{ env.OTA_MANIFEST_BASE_URL }} - OTA_CHANNEL_TAG: ${{ env.OTA_CHANNEL_TAG }} + # OTA_MANIFEST_BASE_URL and OTA_CHANNEL_TAG (what actually make this a + # beta build) come from the workflow-level env: above, which every step + # inherits. Do NOT redeclare them as ${{ env.X }} here — that is a + # self-reference, and if it resolved empty it would blank the channel. run: /usr/bin/env bash build.sh build-firmware ${{ matrix.shard.envs }} - name: Verify beta channel is baked in