From 3448db6e3649d330eced7004d821feff2f59b49f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Br=C3=A1zio?= <jbrazio@gmail.com>
Date: Mon, 16 Jun 2025 02:01:16 +0100
Subject: [PATCH] Rename LED pin

---
 src/helpers/rp2040/WaveshareBoard.cpp |  4 ++--
 src/helpers/rp2040/WaveshareBoard.h   | 15 +++++----------
 2 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/src/helpers/rp2040/WaveshareBoard.cpp b/src/helpers/rp2040/WaveshareBoard.cpp
index f4154dbe..12e3d4f1 100644
--- a/src/helpers/rp2040/WaveshareBoard.cpp
+++ b/src/helpers/rp2040/WaveshareBoard.cpp
@@ -7,8 +7,8 @@ void WaveshareBoard::begin() {
   // for future use, sub-classes SHOULD call this from their begin()
   startup_reason = BD_STARTUP_NORMAL;
 
-#ifdef PIN_LED_BUILTIN
-  pinMode(PIN_LED_BUILTIN, OUTPUT);
+#ifdef P_LORA_TX_LED
+  pinMode(P_LORA_TX_LED, OUTPUT);
 #endif
 
 #ifdef PIN_VBAT_READ
diff --git a/src/helpers/rp2040/WaveshareBoard.h b/src/helpers/rp2040/WaveshareBoard.h
index 0aa136ab..492d54df 100644
--- a/src/helpers/rp2040/WaveshareBoard.h
+++ b/src/helpers/rp2040/WaveshareBoard.h
@@ -13,13 +13,11 @@
 #define P_LORA_SCLK              14
 #define P_LORA_MISO              24
 #define P_LORA_MOSI              15
+#define P_LORA_TX_LED            25
 
 #define SX126X_DIO2_AS_RF_SWITCH true
 #define SX126X_DIO3_TCXO_VOLTAGE 0
 
-// built-ins
-#define PIN_LED_BUILTIN          25
-
 // This board has no built-in way to read battery voltage
 // #define PIN_VBAT_READ    26
 // #define BATTERY_SAMPLES  8
@@ -33,13 +31,10 @@ public:
   void begin();
   uint8_t getStartupReason() const override { return startup_reason; }
 
-  void onBeforeTransmit() override {
-    digitalWrite(PIN_LED_BUILTIN, HIGH); // turn TX LED on
-  }
-
-  void onAfterTransmit() override {
-    digitalWrite(PIN_LED_BUILTIN, LOW); // turn TX LED off
-  }
+#ifdef P_LORA_TX_LED
+  void onBeforeTransmit() override { digitalWrite(P_LORA_TX_LED, HIGH); }
+  void onAfterTransmit() override { digitalWrite(P_LORA_TX_LED, LOW); }
+#endif
 
   uint16_t getBattMilliVolts() override {
 #if defined(PIN_VBAT_READ) && defined(ADC_MULTIPLIER)