From ac8ec172ef74e21bf0febc5e37c416eac88149e2 Mon Sep 17 00:00:00 2001 From: ViezeVingertjes Date: Sat, 6 Sep 2025 20:42:11 +0200 Subject: [PATCH] T1000-E: refactor GPS initialization; set GPS_RESETB pin as OUTPUT and remove redundant pin settings --- variants/t1000-e/target.cpp | 9 --------- variants/t1000-e/variant.cpp | 3 ++- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/variants/t1000-e/target.cpp b/variants/t1000-e/target.cpp index 06509c4f..2a6380d5 100644 --- a/variants/t1000-e/target.cpp +++ b/variants/t1000-e/target.cpp @@ -146,15 +146,6 @@ void T1000SensorManager::stop_gps() { bool T1000SensorManager::begin() { // init GPS Serial1.begin(115200); - - // make sure gps pin are off - digitalWrite(GPS_VRTC_EN, LOW); - digitalWrite(GPS_RESET, LOW); - digitalWrite(GPS_SLEEP_INT, LOW); - digitalWrite(GPS_RTC_INT, LOW); - pinMode(GPS_RESETB, OUTPUT); - digitalWrite(GPS_RESETB, LOW); - return true; } diff --git a/variants/t1000-e/variant.cpp b/variants/t1000-e/variant.cpp index f17b3a8d..f9328e3b 100644 --- a/variants/t1000-e/variant.cpp +++ b/variants/t1000-e/variant.cpp @@ -69,7 +69,7 @@ void initVariant() pinMode(BATTERY_PIN, INPUT); pinMode(EXT_CHRG_DETECT, INPUT); pinMode(EXT_PWR_DETECT, INPUT); - pinMode(GPS_RESETB, INPUT); + pinMode(GPS_RESETB, OUTPUT); pinMode(PIN_BUTTON1, INPUT); pinMode(PIN_3V3_EN, OUTPUT); @@ -92,5 +92,6 @@ void initVariant() digitalWrite(GPS_VRTC_EN, LOW); digitalWrite(GPS_SLEEP_INT, HIGH); digitalWrite(GPS_RTC_INT, LOW); + digitalWrite(GPS_RESETB, LOW); digitalWrite(LED_PIN, LOW); }