From ffa76016ff7cef85de4e7d32c5b7f205fe8e0c4a Mon Sep 17 00:00:00 2001 From: tuzzmaniandevil Date: Fri, 8 May 2026 11:14:22 +1200 Subject: [PATCH] Address two comments from PR --- examples/kiss_modem/KissModem.cpp | 5 +++-- examples/kiss_modem/KissModem.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/kiss_modem/KissModem.cpp b/examples/kiss_modem/KissModem.cpp index 03ea7d6b..eeab1501 100644 --- a/examples/kiss_modem/KissModem.cpp +++ b/examples/kiss_modem/KissModem.cpp @@ -130,8 +130,7 @@ void KissModem::processFrame() { _pending_tx_len = data_len; _has_pending_tx = true; } else if (_has_pending_tx) { - uint8_t result = 0x00; - writeHardwareFrame(HW_RESP_TX_DONE, &result, 1); + writeHardwareError(HW_ERR_TX_BUSY); } break; @@ -296,6 +295,8 @@ void KissModem::processTx() { _tx_timer = millis(); _tx_state = TX_SENDING; } else { + uint8_t result = 0x00; + writeHardwareFrame(HW_RESP_TX_DONE, &result, 1); _has_pending_tx = false; _tx_state = TX_IDLE; } diff --git a/examples/kiss_modem/KissModem.h b/examples/kiss_modem/KissModem.h index 66ce4424..bbe99d6d 100644 --- a/examples/kiss_modem/KissModem.h +++ b/examples/kiss_modem/KissModem.h @@ -72,6 +72,7 @@ #define HW_ERR_MAC_FAILED 0x04 #define HW_ERR_UNKNOWN_CMD 0x05 #define HW_ERR_ENCRYPT_FAILED 0x06 +#define HW_ERR_TX_BUSY 0x07 #define KISS_FIRMWARE_VERSION 1