dandri/ZephCore
1
0
Fork 0
mirror of https://github.com/liquidraver/ZephCore.git synced 2026-10-15 14:19:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

leds: drop unused esp32s3_pwm_led.conf, fix stale WT2 comment

Browse Source 
CONFIG_PWM now comes from each board.conf (see "prefs: move
led_brightness after wifi_pwd; enable PWM in board.conf"), so the
EXTRA_CONF_FILE fragment is no longer referenced anywhere and can go.

The WT2 PWM LED node comment still said "Option 1" and "RAM-only",
both stale: the design no longer needs that internal name, and the
brightness has been persisted since the earlier commit in this branch.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
ZephCore T096
2026-10-08 18:27:01 +02:00
co-authored by Claude Sonnet 5
parent fc0723a8ec
commit e5e927e530
2 changed files with 4 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
zephcore/boards/common/esp32s3_pwm_led.conf
-15
View File
@@ -1,15 +0,0 @@
# Enable PWM on ESP32-S3 sysbuild targets (shared heartbeat/TX LED brightness,
# see the heartbeat-pwm-led / lora-tx-pwm-led devicetree aliases consumed by
# helpers/ui/ui_common.c and adapters/board/ZephyrBoard.cpp).
#
# Deliberately NOT in the board *_defconfig: that file is shared by every
# sysbuild image for the board, including mcuboot, whose minimal kernel
# config has no k_sem_give()/k_sem_take() -- CONFIG_PWM=y there links fine for
# the app image but fails mcuboot's link with "undefined reference to
# z_impl_k_sem_give/take" (drivers/pwm/pwm_led_esp32.c uses a semaphore).
# EXTRA_CONF_FILE scopes this to the app ("zephcore") image only.
#
# Build with:
# -DEXTRA_CONF_FILE="boards/common/esp32s3_usb.conf;boards/common/esp32s3_pwm_led.conf"
CONFIG_PWM=y
zephcore/boards/esp32/heltec_wireless_tracker_v2/heltec_wireless_tracker_v2_procpu.dts
+4 -5
View File
@@ -74,11 +74,10 @@
/* Same GPIO18 net as status_led above, driven through the LEDC PWM
* peripheral instead of a raw GPIO write. Single LED doubling as
* heartbeat, message/shutdown flash and LoRa TX indicator (same
* "Option 1" shared-brightness pattern as T096, see helpers/ui/ui_common.c
* and adapters/board/ZephyrBoard.cpp: heartbeat-pwm-led/lora-tx-pwm-led
* aliases give every one of those events a single 0-100 brightness knob,
* RAM-only, on top of the existing persisted on/off gate. */
* heartbeat, message/shutdown flash and LoRa TX indicator: the
* heartbeat-pwm-led/lora-tx-pwm-led aliases give every one of those
* events a single persisted 0-100 brightness knob, on top of the
* existing persisted on/off gate. */
pwm_leds {
compatible = "pwm-leds";