mirror of
https://github.com/MeshCore-Beacon/beacon-server.git
synced 2026-10-15 18:19:57 +00:00
* perf(routes): batch cross-IATA and hash route search (#216) One search fired a /routes/cross request per IATA pair (138k on 2026-10-08). Route search now takes an optional iatas list and runs a fixed number of index-backed queries. /info advertises built-in minimum client versions. * chore: bump version to 2.0.4
214 lines
6.7 KiB
Go
214 lines
6.7 KiB
Go
// Copyright 2026 Beacon Contributors
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
|
|
package db
|
|
|
|
import (
|
|
"context"
|
|
"embed"
|
|
"errors"
|
|
"fmt"
|
|
"io/fs"
|
|
"log/slog"
|
|
"regexp"
|
|
"sort"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/jackc/pgx/v5"
|
|
"github.com/jackc/pgx/v5/pgconn"
|
|
"github.com/jackc/pgx/v5/pgxpool"
|
|
)
|
|
|
|
//go:embed migrations/*.sql
|
|
var migrationFiles embed.FS
|
|
|
|
// execQuerier is the slice of pgxpool.Pool / pgx.Conn migrations need; it lets
|
|
// integration tests drive applyMigration over a plain connection.
|
|
type execQuerier interface {
|
|
Exec(ctx context.Context, sql string, args ...any) (pgconn.CommandTag, error)
|
|
QueryRow(ctx context.Context, sql string, args ...any) pgx.Row
|
|
}
|
|
|
|
var (
|
|
lineCommentRe = regexp.MustCompile(`(?m)--[^\n]*`)
|
|
concurrentIndexRe = regexp.MustCompile(`(?is)\bCREATE\s+(?:UNIQUE\s+)?INDEX\s+CONCURRENTLY\s+(?:IF\s+NOT\s+EXISTS\s+)?("?[\w.]+"?)`)
|
|
// Statements that refuse to run inside a transaction block.
|
|
nonTransactionalRe = regexp.MustCompile(`(?i)\b(?:CONCURRENTLY|VACUUM)\b`)
|
|
)
|
|
|
|
// migrationLockKey serialises RunMigrations across instances sharing a database.
|
|
const migrationLockKey int64 = 0x6265_6163_6f6e // "beacon"
|
|
|
|
// concurrentIndexName returns the index a CREATE INDEX CONCURRENTLY migration builds.
|
|
func concurrentIndexName(sql string) (string, bool) {
|
|
m := concurrentIndexRe.FindStringSubmatch(lineCommentRe.ReplaceAllString(sql, ""))
|
|
if m == nil {
|
|
return "", false
|
|
}
|
|
return strings.Trim(m[1], `"`), true
|
|
}
|
|
|
|
// isDuplicateRelation reports SQLSTATE 42P07 (relation already exists).
|
|
func isDuplicateRelation(err error) bool {
|
|
var pgErr *pgconn.PgError
|
|
return errors.As(err, &pgErr) && pgErr.Code == "42P07"
|
|
}
|
|
|
|
// applyMigration runs one file outside a transaction. An interrupted CREATE INDEX
|
|
// CONCURRENTLY leaves an invalid index that trips 42P07 on retry; drop it and rebuild once.
|
|
func applyMigration(ctx context.Context, db execQuerier, sql string) error {
|
|
_, err := db.Exec(ctx, sql)
|
|
if err == nil || !isDuplicateRelation(err) {
|
|
return err
|
|
}
|
|
name, ok := concurrentIndexName(sql)
|
|
if !ok {
|
|
return err
|
|
}
|
|
ident := pgx.Identifier(strings.Split(name, ".")).Sanitize()
|
|
var valid bool
|
|
if scanErr := db.QueryRow(ctx,
|
|
"SELECT indisvalid FROM pg_index WHERE indexrelid = to_regclass($1)", ident,
|
|
).Scan(&valid); scanErr != nil {
|
|
if errors.Is(scanErr, pgx.ErrNoRows) {
|
|
return err
|
|
}
|
|
return fmt.Errorf("%w (checking index %s: %v)", err, name, scanErr)
|
|
}
|
|
if valid {
|
|
slog.Info(fmt.Sprintf("index %s already built, recording migration", name), "component", "db")
|
|
return nil
|
|
}
|
|
if _, dropErr := db.Exec(ctx, "DROP INDEX CONCURRENTLY IF EXISTS "+ident); dropErr != nil {
|
|
return fmt.Errorf("dropping invalid index %s: %w", name, dropErr)
|
|
}
|
|
slog.Warn(fmt.Sprintf("dropped invalid index %s, rebuilding", name), "component", "db")
|
|
_, err = db.Exec(ctx, sql)
|
|
return err
|
|
}
|
|
|
|
// applyAndRecord applies a migration and its ledger row. Without CONCURRENTLY both go in
|
|
// one simple-protocol Exec, an implicit transaction, so a crash can't apply one without the other.
|
|
func applyAndRecord(ctx context.Context, db execQuerier, name, sql string) error {
|
|
record := "INSERT INTO schema_migrations (filename) VALUES ('" + strings.ReplaceAll(name, "'", "''") + "')"
|
|
if !nonTransactionalRe.MatchString(lineCommentRe.ReplaceAllString(sql, "")) {
|
|
_, err := db.Exec(ctx, sql+"\n;\n"+record)
|
|
return err
|
|
}
|
|
if err := applyMigration(ctx, db, sql); err != nil {
|
|
return err
|
|
}
|
|
_, err := db.Exec(ctx, record)
|
|
return err
|
|
}
|
|
|
|
const baselineMigration = "001_baseline.sql"
|
|
|
|
var errPreBaseline = errors.New("database schema predates Beacon 2.0.0; 2.0.0 needs a fresh database")
|
|
|
|
// checkBaseline refuses databases built by the 1.x migration chain, which the
|
|
// 2.0.0 baseline replaced; applying it on top would collide with existing tables.
|
|
func checkBaseline(ctx context.Context, db execQuerier) error {
|
|
var ledger, hasBaseline, hasPackets bool
|
|
err := db.QueryRow(ctx, `
|
|
SELECT EXISTS(SELECT 1 FROM schema_migrations),
|
|
EXISTS(SELECT 1 FROM schema_migrations WHERE filename = $1),
|
|
to_regclass('packets') IS NOT NULL`, baselineMigration,
|
|
).Scan(&ledger, &hasBaseline, &hasPackets)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to check migration baseline: %w", err)
|
|
}
|
|
if (ledger && !hasBaseline) || (!ledger && hasPackets) {
|
|
return errPreBaseline
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func RunMigrations(ctx context.Context, pool *pgxpool.Pool) error {
|
|
conn, err := pool.Acquire(ctx)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to acquire migration connection: %w", err)
|
|
}
|
|
defer conn.Release()
|
|
// Poll, don't block: a waiter in pg_advisory_lock holds a snapshot that the
|
|
// holder's CREATE INDEX CONCURRENTLY waits on, which deadlocks.
|
|
for {
|
|
var locked bool
|
|
if err := conn.QueryRow(ctx, "SELECT pg_try_advisory_lock($1)", migrationLockKey).Scan(&locked); err != nil {
|
|
return fmt.Errorf("failed to take migration lock: %w", err)
|
|
}
|
|
if locked {
|
|
break
|
|
}
|
|
select {
|
|
case <-ctx.Done():
|
|
return fmt.Errorf("failed to take migration lock: %w", ctx.Err())
|
|
case <-time.After(250 * time.Millisecond):
|
|
}
|
|
}
|
|
defer func() {
|
|
// A session lock outlives Release; drop the connection if unlock fails.
|
|
if _, err := conn.Exec(context.Background(), "SELECT pg_advisory_unlock($1)", migrationLockKey); err != nil {
|
|
_ = conn.Conn().Close(context.Background())
|
|
}
|
|
}()
|
|
return runMigrations(ctx, conn)
|
|
}
|
|
|
|
func runMigrations(ctx context.Context, pool execQuerier) error {
|
|
_, err := pool.Exec(ctx, `
|
|
CREATE TABLE IF NOT EXISTS schema_migrations (
|
|
filename TEXT PRIMARY KEY,
|
|
applied_at TIMESTAMPTZ NOT NULL DEFAULT NOW()
|
|
)
|
|
`)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to create schema_migrations: %w", err)
|
|
}
|
|
|
|
if err := checkBaseline(ctx, pool); err != nil {
|
|
return err
|
|
}
|
|
|
|
entries, err := fs.ReadDir(migrationFiles, "migrations")
|
|
if err != nil {
|
|
return fmt.Errorf("failed to read migrations: %w", err)
|
|
}
|
|
|
|
sort.Slice(entries, func(i, j int) bool {
|
|
return entries[i].Name() < entries[j].Name()
|
|
})
|
|
|
|
for _, entry := range entries {
|
|
if !strings.HasSuffix(entry.Name(), ".sql") {
|
|
continue
|
|
}
|
|
var already bool
|
|
err := pool.QueryRow(
|
|
ctx,
|
|
"SELECT EXISTS(SELECT 1 FROM schema_migrations WHERE filename = $1)",
|
|
entry.Name(),
|
|
).Scan(&already)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to check migration %s: %w", entry.Name(), err)
|
|
}
|
|
if already {
|
|
continue
|
|
}
|
|
|
|
sql, err := migrationFiles.ReadFile("migrations/" + entry.Name())
|
|
if err != nil {
|
|
return fmt.Errorf("failed to read migration %s: %w", entry.Name(), err)
|
|
}
|
|
|
|
if err := applyAndRecord(ctx, pool, entry.Name(), string(sql)); err != nil {
|
|
return fmt.Errorf("failed to apply migration %s: %w", entry.Name(), err)
|
|
}
|
|
|
|
slog.Info(fmt.Sprintf("applied migration: %s", entry.Name()), "component", "db")
|
|
}
|
|
|
|
return nil
|
|
}
|