From 495eeedd244d5ca89f97282dcef5e4085a996ab3 Mon Sep 17 00:00:00 2001
From: timedout <git@nexy7574.co.uk>
Date: Fri, 2 Oct 2026 17:41:38 +0100
Subject: [PATCH] style: Don't return Allow in an else block

---
 src/ruminuwuity/invite_permission_config.rs | 5 +++--
 src/service/users/account.rs                | 8 ++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/ruminuwuity/invite_permission_config.rs b/src/ruminuwuity/invite_permission_config.rs
index cc7458d80..80743bd8d 100644
--- a/src/ruminuwuity/invite_permission_config.rs
+++ b/src/ruminuwuity/invite_permission_config.rs
@@ -18,6 +18,7 @@
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum FilterLevel {
 	Allow,
+	ExplicitAllow,
 	Ignore,
 	Block,
 }
@@ -124,7 +125,7 @@ pub fn user_filter_level(&self, user: &UserId) -> FilterLevel {
 		} else if !self.enabled {
 			FilterLevel::Allow
 		} else if Self::matches(&self.allowed_users, user.as_str()) {
-			FilterLevel::Allow
+			FilterLevel::ExplicitAllow
 		} else if Self::matches(&self.ignored_users, user.as_str()) {
 			FilterLevel::Ignore
 		} else if Self::matches(&self.blocked_users, user.as_str()) {
@@ -144,7 +145,7 @@ pub fn server_filter_level(&self, server: &ServerName) -> FilterLevel {
 		} else {
 			let server = server.host();
 			if Self::matches(&self.allowed_servers, server) {
-				FilterLevel::Allow
+				FilterLevel::ExplicitAllow
 			} else if Self::matches(&self.ignored_servers, server) {
 				FilterLevel::Ignore
 			} else if Self::matches(&self.blocked_servers, server) {
diff --git a/src/service/users/account.rs b/src/service/users/account.rs
index f96013b32..dd73f5255 100644
--- a/src/service/users/account.rs
+++ b/src/service/users/account.rs
@@ -119,14 +119,14 @@ pub async fn invite_filter_level(
 					.check_msc4494_mutual_room(sender_user, recipient_user)
 					.await
 			{
-				FilterLevel::Block
-			} else {
-				FilterLevel::Allow
+				return FilterLevel::Block;
 			}
+
+			FilterLevel::Allow
 		}
 	}
 
-	/// Checks that sender and recipient share at least one rule that has a join
+	/// Checks that sender and recipient share at least one room that has a join
 	/// rule other than `public`.
 	async fn check_msc4494_mutual_room(&self, sender: &UserId, recipient: &UserId) -> bool {
 		let mut mutual_rooms = std::pin::pin!(