From 6115bb31010dcb6bc9ef463aef57c526e09cdd61 Mon Sep 17 00:00:00 2001 From: Ginger Date: Tue, 9 Jun 2026 13:58:03 -0400 Subject: [PATCH] refactor: Remove redundant destination check in server auth logic Ruma already does this check for us --- src/api/router/auth.rs | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/api/router/auth.rs b/src/api/router/auth.rs index 69577ba25..8077ca04c 100644 --- a/src/api/router/auth.rs +++ b/src/api/router/auth.rs @@ -129,15 +129,6 @@ async fn verify + Any, B: AsRef<[u8]> request: &hyper::Request, _query: AuthQueryParams, ) -> Result { - let destination = services.globals.server_name(); - if output - .destination - .as_ref() - .is_some_and(|supplied_destination| supplied_destination != destination) - { - return Err!(Request(Unauthorized("Destination mismatch."))); - } - let key = services .server_keys .get_verify_key(&output.origin, &output.key) @@ -149,7 +140,7 @@ async fn verify + Any, B: AsRef<[u8]> let keys: PubKeys = [(output.key.to_string(), key.key)].into(); let keys: PubKeyMap = [(output.origin.as_str().into(), keys)].into(); - match output.verify_request(request, destination, &keys) { + match output.verify_request(request, services.globals.server_name(), &keys) { | Ok(()) => { if services .moderation