dandri/i2p.i2p
1
0
Fork 0
mirror of https://github.com/i2p/i2p.i2p.git synced 2026-05-25 01:35:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stats: Fix 60s stat getAverage() returning 20% high

Browse Source 
due to CoalesceStatsEvent being on a 50s timer

- Caused by rounding in Rate.coalesce()
- Affected data on /stats, Prometheus plugin, console sidebar, and internal use
- Did not affect graphs
- Apparently dates back to original jrandom code
This commit is contained in:
zzz
2026-03-19 10:25:12 -04:00
parent 80bb2b767f
commit 174061bd2d
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/java/src/net/i2p/stat/Rate.java
+10 -10
View File
@@ -214,7 +214,6 @@ public class Rate {
private static final int SLACK = 2000;
public void coalesce() {
long now = now();
double correctedTotalValue; // for summaryListener which divides by rounded EventCount
synchronized (this) {
long measuredPeriod = now - _lastCoalesceDate;
if (measuredPeriod < _period - SLACK) {
@@ -228,15 +227,15 @@ public class Rate {
// how much were we off by? (so that we can sample down the measured values)
float periodFactor = measuredPeriod / (float)_period;
_lastTotalValue = _currentTotalValue / periodFactor;
_lastEventCount = (int) (0.499999 + (_currentEventCount / periodFactor));
// no, we can't scale these, because eventCount is an int, so
// only totalValue scales accurately,
// resulting in scaling errors in getAverageValue()
//_lastTotalValue = _currentTotalValue / periodFactor;
//_lastEventCount = (int) (0.499999 + (_currentEventCount / periodFactor));
_lastTotalValue = _currentTotalValue;
_lastEventCount = _currentEventCount;
_lastTotalEventTime = (int) (_currentTotalEventTime / periodFactor);
_lastCoalesceDate = now;
if (_currentEventCount == 0)
correctedTotalValue = 0;
else
correctedTotalValue = _currentTotalValue *
(_lastEventCount / (double) _currentEventCount);
if (_lastTotalValue >= _extremeTotalValue) { // get the most recent if identical
_extremeTotalValue = _lastTotalValue;
@@ -248,8 +247,9 @@ public class Rate {
_currentEventCount = 0;
_currentTotalEventTime = 0;
}
if (_summaryListener != null)
_summaryListener.add(correctedTotalValue, _lastEventCount, _lastTotalEventTime, _period);
RateSummaryListener rsl = _summaryListener;
if (rsl != null)
rsl.add(_lastTotalValue, _lastEventCount, _lastTotalEventTime, _period);
}
public void setSummaryListener(RateSummaryListener listener) { _summaryListener = listener; }