dandri/i2p.i2p
1
0
Fork 0
mirror of https://github.com/i2p/i2p.i2p.git synced 2026-05-14 09:45:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Crypto: Use constant-time modPow() for ElG private key operations

Browse Source 
Deprecate unused ElGamalSigEngine

reported by: bottomlineit.co.za
This commit is contained in:
zzz
2026-05-01 11:34:28 -04:00
parent 93be42925b
commit 66a270e7a2
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/java/src/net/i2p/crypto/KeyGenerator.java
+4 -4
View File
@@ -161,7 +161,7 @@ public final class KeyGenerator {
*/
public SimpleDataStructure[] generatePKIKeys() {
BigInteger a = new NativeBigInteger(getElGamalExponentSize(), _context.random());
BigInteger aalpha = CryptoConstants.elgg.modPow(a, CryptoConstants.elgp);
BigInteger aalpha = CryptoConstants.elgg.modPowCT(a, CryptoConstants.elgp);
SimpleDataStructure[] keys = new SimpleDataStructure[2];
@@ -236,7 +236,7 @@ public final class KeyGenerator {
switch (type) {
case ELGAMAL_2048:
BigInteger a = new NativeBigInteger(1, priv.toByteArray());
BigInteger aalpha = CryptoConstants.elgg.modPow(a, CryptoConstants.elgp);
BigInteger aalpha = CryptoConstants.elgg.modPowCT(a, CryptoConstants.elgp);
try {
data = SigUtil.rectify(aalpha, PublicKey.KEYSIZE_BYTES);
} catch (InvalidKeyException ike) {
@@ -289,7 +289,7 @@ public final class KeyGenerator {
x = new NativeBigInteger(160, _context.random());
} while (x.compareTo(CryptoConstants.dsaq) >= 0 || x.equals(BigInteger.ZERO));
BigInteger y = CryptoConstants.dsag.modPow(x, CryptoConstants.dsap);
BigInteger y = CryptoConstants.dsag.modPowCT(x, CryptoConstants.dsap);
keys[0] = new SigningPublicKey();
keys[1] = new SigningPrivateKey();
try {
@@ -378,7 +378,7 @@ public final class KeyGenerator {
switch (type.getBaseAlgorithm()) {
case DSA:
BigInteger x = new NativeBigInteger(1, priv.toByteArray());
BigInteger y = CryptoConstants.dsag.modPow(x, CryptoConstants.dsap);
BigInteger y = CryptoConstants.dsag.modPowCT(x, CryptoConstants.dsap);
SigningPublicKey pub = new SigningPublicKey();
pub.setData(SigUtil.rectify(y, SigningPublicKey.KEYSIZE_BYTES));
return pub;
core/java/src/net/i2p/crypto/elgamal/ElGamalSigEngine.java
+2
View File
@@ -23,7 +23,9 @@ import net.i2p.util.RandomSource;
* ref: https://en.wikipedia.org/wiki/ElGamal_signature_scheme
*
* @since 0.9.25
* @deprecated unused, unsupported by SigType or SigUtil, may need constant-time fixes
*/
@Deprecated
public final class ElGamalSigEngine extends Signature {
private final MessageDigest digest;
private ElGamalKey key;