From dec98e6b8df9d0dafb92581cff0637eba1085dce Mon Sep 17 00:00:00 2001 From: eyedeekay Date: Mon, 9 Oct 2023 14:53:52 -0400 Subject: [PATCH] Router: remove the redundant casts, fixes #438 --- .../net/i2p/router/transport/ntcp/InboundEstablishState.java | 2 +- .../java/src/net/i2p/router/transport/ntcp/NTCPConnection.java | 2 +- .../net/i2p/router/transport/udp/InboundEstablishState2.java | 2 +- router/java/src/net/i2p/router/transport/udp/PeerState2.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/router/java/src/net/i2p/router/transport/ntcp/InboundEstablishState.java b/router/java/src/net/i2p/router/transport/ntcp/InboundEstablishState.java index a11afdbb0..42a7010d1 100644 --- a/router/java/src/net/i2p/router/transport/ntcp/InboundEstablishState.java +++ b/router/java/src/net/i2p/router/transport/ntcp/InboundEstablishState.java @@ -691,7 +691,7 @@ class InboundEstablishState extends EstablishBase implements NTCP2Payload.Payloa try { RouterInfo old = _context.netDb().store(h, ri); if (flood && !ri.equals(old)) { - FloodfillNetworkDatabaseFacade fndf = (FloodfillNetworkDatabaseFacade) _context.netDb(); + FloodfillNetworkDatabaseFacade fndf = _context.netDb(); if (fndf.floodConditional(ri)) { if (_log.shouldDebug()) _log.debug("Flooded the RI: " + h); diff --git a/router/java/src/net/i2p/router/transport/ntcp/NTCPConnection.java b/router/java/src/net/i2p/router/transport/ntcp/NTCPConnection.java index 936f0edd0..2cc789fd0 100644 --- a/router/java/src/net/i2p/router/transport/ntcp/NTCPConnection.java +++ b/router/java/src/net/i2p/router/transport/ntcp/NTCPConnection.java @@ -1670,7 +1670,7 @@ public class NTCPConnection implements Closeable { return; RouterInfo old = _context.netDb().store(h, ri); if (flood && !ri.equals(old)) { - FloodfillNetworkDatabaseFacade fndf = (FloodfillNetworkDatabaseFacade) _context.netDb(); + FloodfillNetworkDatabaseFacade fndf = _context.netDb(); if ((old == null || ri.getPublished() > old.getPublished()) && fndf.floodConditional(ri)) { if (_log.shouldDebug()) diff --git a/router/java/src/net/i2p/router/transport/udp/InboundEstablishState2.java b/router/java/src/net/i2p/router/transport/udp/InboundEstablishState2.java index 65e3b8fb0..077a5a367 100644 --- a/router/java/src/net/i2p/router/transport/udp/InboundEstablishState2.java +++ b/router/java/src/net/i2p/router/transport/udp/InboundEstablishState2.java @@ -376,7 +376,7 @@ class InboundEstablishState2 extends InboundEstablishState implements SSU2Payloa try { RouterInfo old = _context.netDb().store(h, ri); if (flood && !ri.equals(old)) { - FloodfillNetworkDatabaseFacade fndf = (FloodfillNetworkDatabaseFacade) _context.netDb(); + FloodfillNetworkDatabaseFacade fndf = _context.netDb(); if (fndf.floodConditional(ri)) { if (_log.shouldDebug()) _log.debug("Flooded the RI: " + h); diff --git a/router/java/src/net/i2p/router/transport/udp/PeerState2.java b/router/java/src/net/i2p/router/transport/udp/PeerState2.java index 608c147f3..ed7acb544 100644 --- a/router/java/src/net/i2p/router/transport/udp/PeerState2.java +++ b/router/java/src/net/i2p/router/transport/udp/PeerState2.java @@ -634,7 +634,7 @@ public class PeerState2 extends PeerState implements SSU2Payload.PayloadCallback return; RouterInfo old = _context.netDb().store(h, ri); if (flood && !ri.equals(old)) { - FloodfillNetworkDatabaseFacade fndf = (FloodfillNetworkDatabaseFacade) _context.netDb(); + FloodfillNetworkDatabaseFacade fndf = _context.netDb(); if ((old == null || ri.getPublished() > old.getPublished()) && fndf.floodConditional(ri)) { if (_log.shouldDebug())