mirror of
https://github.com/i2p/i2p.i2p.git
synced 2026-05-24 10:15:23 +00:00
zzz
e7774feb12
Hopefully fixes rare case where torrents get stuck. Tested that it doesn't break anything, but was never able to reproduce the issue. As reported in torrent at http://tracker2.postman.i2p/index.php?view=TorrentDetail&id=85798 Fix adapted and greatly simplified from source code included in that torrent. Apparently from old trac ticket #691. Credit: smtorrents Also: - Fix place where removePeerFromPieces() was being called twice, once directly and once from disconnect(true). - Fix javadoc for Peer.disconnect() - Fix log typo - Add comments Description from OP of that torrent: This update now finally fixes the decades old ticket number 691 which prevents torrents to complete from time to time. The bug manifests itself by keeping a couple of outstanding pieces (> 8, so we never get into the endgame) that are marked as requested from a peerID, with a corresponding peer that has long gone. Those pieces are never requested from any other peer. There are consequently more peerIDs than peers connected. The only place in code, where peers and peer IDs are mixed up, is a reconnect logic that tries to reuse an existing connection while keeping outstanding requests from the old connection, when the other end tries to reconnect. Keeping old requests is faulty by itself because someone reconnecting to us will definitely have dropped our previous requests, so we must do the same. The fix now always drops previous connections along with all outstanding requests.