From 1397c93de1909fb3a5146f022a834929b9d762cd Mon Sep 17 00:00:00 2001 From: Jeff Becker Date: Fri, 3 Apr 2026 09:02:12 -0400 Subject: [PATCH 1/3] Fixup i2cp option on reconfigure. Make sure i2cp.dontPublishLeaseSet option logic correctly applies on reconfigure. --- libi2pd/Destination.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libi2pd/Destination.cpp b/libi2pd/Destination.cpp index b8517712..aa77b09e 100644 --- a/libi2pd/Destination.cpp +++ b/libi2pd/Destination.cpp @@ -161,10 +161,12 @@ namespace client CleanUp (); // GarlicDestination } - bool LeaseSetDestination::Reconfigure(const i2p::util::Mapping& params) - { - params.Get (I2CP_PARAM_DONT_PUBLISH_LEASESET, m_IsPublic); + bool + LeaseSetDestination::Reconfigure(const i2p::util::Mapping ¶ms) { + bool dontPublishLeaseSet = true; + params.Get(I2CP_PARAM_DONT_PUBLISH_LEASESET, dontPublishLeaseSet); + m_IsPublic = !dontPublishLeaseSet; auto numTags = GetNumTags (); params.Get (I2CP_PARAM_TAGS_TO_SEND, numTags); auto numRatchetInboundTags = GetNumRatchetInboundTags (); From ac5ba2dbf0fa0fcec6c20da7d81ca1fd5ed58f4a Mon Sep 17 00:00:00 2001 From: jeff Date: Fri, 3 Apr 2026 09:13:06 -0400 Subject: [PATCH 2/3] Update libi2pd/Destination.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- libi2pd/Destination.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libi2pd/Destination.cpp b/libi2pd/Destination.cpp index aa77b09e..e2eadbe6 100644 --- a/libi2pd/Destination.cpp +++ b/libi2pd/Destination.cpp @@ -164,9 +164,9 @@ namespace client bool LeaseSetDestination::Reconfigure(const i2p::util::Mapping ¶ms) { - bool dontPublishLeaseSet = true; + bool dontPublishLeaseSet = !m_IsPublic; params.Get(I2CP_PARAM_DONT_PUBLISH_LEASESET, dontPublishLeaseSet); - m_IsPublic = !dontPublishLeaseSet; + m_IsPublic = !dontPublishLeaseSet; auto numTags = GetNumTags (); params.Get (I2CP_PARAM_TAGS_TO_SEND, numTags); auto numRatchetInboundTags = GetNumRatchetInboundTags (); From af8a3decbfc1aa24ccfd16f4d9b9280918185522 Mon Sep 17 00:00:00 2001 From: jeff Date: Fri, 3 Apr 2026 09:13:44 -0400 Subject: [PATCH 3/3] Update libi2pd/Destination.cpp style fix Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- libi2pd/Destination.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libi2pd/Destination.cpp b/libi2pd/Destination.cpp index e2eadbe6..c579c067 100644 --- a/libi2pd/Destination.cpp +++ b/libi2pd/Destination.cpp @@ -162,8 +162,8 @@ namespace client } - bool - LeaseSetDestination::Reconfigure(const i2p::util::Mapping ¶ms) { + bool LeaseSetDestination::Reconfigure (const i2p::util::Mapping& params) + { bool dontPublishLeaseSet = !m_IsPublic; params.Get(I2CP_PARAM_DONT_PUBLISH_LEASESET, dontPublishLeaseSet); m_IsPublic = !dontPublishLeaseSet;