From 050909e627c06fe6a2818c4e47a1dc87f03fc1a7 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Sat, 4 Apr 2026 00:54:48 +0530 Subject: [PATCH] Enable data tracks by default. (#4429) --- pkg/config/config.go | 13 +++++++------ pkg/rtc/signalling/signallerasync.go | 2 +- pkg/service/rtcservice.go | 8 ++++---- pkg/sfu/downtrack.go | 2 +- 4 files changed, 13 insertions(+), 12 deletions(-) diff --git a/pkg/config/config.go b/pkg/config/config.go index 8b1182ea1..5da2eff54 100644 --- a/pkg/config/config.go +++ b/pkg/config/config.go @@ -436,12 +436,13 @@ var DefaultConfig = Config{ StreamBufferSize: 1000, ConnectAttempts: 3, }, - PSRPC: rpc.DefaultPSRPCConfig, - Keys: map[string]string{}, - Metric: metric.DefaultMetricConfig, - WebHook: webhook.DefaultWebHookConfig, - NodeStats: DefaultNodeStatsConfig, - API: DefaultAPIConfig(), + PSRPC: rpc.DefaultPSRPCConfig, + Keys: map[string]string{}, + Metric: metric.DefaultMetricConfig, + WebHook: webhook.DefaultWebHookConfig, + NodeStats: DefaultNodeStatsConfig, + API: DefaultAPIConfig(), + EnableDataTracks: true, } func NewConfig(confString string, strictMode bool, c *cli.Command, baseFlags []cli.Flag) (*Config, error) { diff --git a/pkg/rtc/signalling/signallerasync.go b/pkg/rtc/signalling/signallerasync.go index a25486faa..0dc0853ee 100644 --- a/pkg/rtc/signalling/signallerasync.go +++ b/pkg/rtc/signalling/signallerasync.go @@ -63,7 +63,7 @@ func (s *signallerAsync) WriteMessage(msg proto.Message) error { if s.params.Participant.IsDisconnected() { s.params.Logger.Debugw( - "counld not send message to participant, participant disconnected", + "could not send message to participant, participant disconnected", "messageType", getMessageType(msg), ) return nil diff --git a/pkg/service/rtcservice.go b/pkg/service/rtcservice.go index e8c225518..43a7665ae 100644 --- a/pkg/service/rtcservice.go +++ b/pkg/service/rtcservice.go @@ -290,10 +290,10 @@ func (s *RTCService) serve(w http.ResponseWriter, r *http.Request, needsJoinRequ } var ( - roomName livekit.RoomName - roomID livekit.RoomID - participantIdentity livekit.ParticipantIdentity - pID livekit.ParticipantID + roomName livekit.RoomName = "unresolved" + roomID livekit.RoomID = "unresolved" + participantIdentity livekit.ParticipantIdentity = "unresolved" + pID livekit.ParticipantID = "unresolved" loggerResolved bool pi routing.ParticipantInit diff --git a/pkg/sfu/downtrack.go b/pkg/sfu/downtrack.go index adf264cf6..a238b8d11 100644 --- a/pkg/sfu/downtrack.go +++ b/pkg/sfu/downtrack.go @@ -1420,7 +1420,7 @@ func (d *DownTrack) CloseWithFlush(flush bool, isEnding bool) { return } - d.params.Logger.Debugw("close downtrack", "flushBlankFrame", flush) + d.params.Logger.Debugw("close downtrack", "flushBlankFrame", flush, "isEnding", isEnding) if d.bindState.Load() == bindStateBound { d.forwarder.Mute(true, true)