From 0aa8684f1cf09e1275f1f3ff1ffe0a054dd108a5 Mon Sep 17 00:00:00 2001 From: David Colburn Date: Fri, 28 Oct 2022 12:09:37 -0700 Subject: [PATCH] fix activeRecording (#1132) * fix activeRecording * also check if p is nil --- pkg/rtc/room.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/rtc/room.go b/pkg/rtc/room.go index a5d417a1b..165b515cf 100644 --- a/pkg/rtc/room.go +++ b/pkg/rtc/room.go @@ -369,19 +369,19 @@ func (r *Room) RemoveParticipant(identity livekit.ParticipantIdentity, reason ty } } - activeRecording := false - if (p != nil && p.IsRecorder()) || p == nil && r.protoRoom.ActiveRecording { + if (p != nil && p.IsRecorder()) || r.protoRoom.ActiveRecording { + activeRecording := false for _, op := range r.participants { if op.IsRecorder() { activeRecording = true break } } - } - if r.protoRoom.ActiveRecording != activeRecording { - r.protoRoom.ActiveRecording = activeRecording - r.sendRoomUpdateLocked() + if r.protoRoom.ActiveRecording != activeRecording { + r.protoRoom.ActiveRecording = activeRecording + r.sendRoomUpdateLocked() + } } r.lock.Unlock()