From 0bf7b178eb2308cf671b5a5352e602764d9e5a42 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Sun, 28 Sep 2025 10:46:41 +0530 Subject: [PATCH] avoid logging on small values (#3958) --- pkg/sfu/forwardstats.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/sfu/forwardstats.go b/pkg/sfu/forwardstats.go index 00b4e91ff..4e685f085 100644 --- a/pkg/sfu/forwardstats.go +++ b/pkg/sfu/forwardstats.go @@ -11,8 +11,8 @@ import ( ) const ( - highForwardingLatency = 20 * time.Millisecond - skewFactor = 10 + cHighForwardingLatency = 20 * time.Millisecond + cSkewFactor = 10 ) type ForwardStats struct { @@ -38,7 +38,7 @@ func NewForwardStats(latencyUpdateInterval, reportInterval, latencyWindowLength func (s *ForwardStats) Update(arrival, left int64) (int64, bool) { transit := left - arrival isHighForwardingLatency := false - if time.Duration(transit) > highForwardingLatency { + if time.Duration(transit) > cHighForwardingLatency { isHighForwardingLatency = true } @@ -72,7 +72,7 @@ func (s *ForwardStats) GetStats(shortDuration time.Duration) (time.Duration, tim latencyLong, jitterLong := time.Duration(wLong.Mean()), time.Duration(wLong.StdDev()) latencyShort, jitterShort := time.Duration(wShort.Mean()), time.Duration(wShort.StdDev()) - if jitterLong > latencyLong*skewFactor { + if latencyShort > cHighForwardingLatency/2 && jitterLong > latencyLong*cSkewFactor { logger.Infow( "high jitter in forwarding path", "lowest", time.Duration(lowest),