diff --git a/pkg/sfu/buffer/dependencydescriptorparser.go b/pkg/sfu/buffer/dependencydescriptorparser.go index 8cc648b7f..5b2744716 100644 --- a/pkg/sfu/buffer/dependencydescriptorparser.go +++ b/pkg/sfu/buffer/dependencydescriptorparser.go @@ -47,7 +47,6 @@ type DependencyDescriptorParser struct { } func NewDependencyDescriptorParser(ddExtID uint8, logger logger.Logger, onMaxLayerChanged func(int32, int32)) *DependencyDescriptorParser { - logger.Infow("creating dependency descriptor parser", "ddExtID", ddExtID) return &DependencyDescriptorParser{ ddExtID: ddExtID, logger: logger, @@ -86,7 +85,7 @@ func (r *DependencyDescriptorParser) Parse(pkt *rtp.Packet) (*ExtDependencyDescr _, err := ext.Unmarshal(ddBuf) if err != nil { if err != dd.ErrDDReaderNoStructure { - r.logger.Warnw("failed to parse generic dependency descriptor", err, "payload", pkt.PayloadType, "ddbufLen", len(ddBuf)) + r.logger.Infow("failed to parse generic dependency descriptor", err, "payload", pkt.PayloadType, "ddbufLen", len(ddBuf)) } return nil, videoLayer, err } @@ -119,7 +118,7 @@ func (r *DependencyDescriptorParser) Parse(pkt *rtp.Packet) (*ExtDependencyDescr } if r.structure == nil || ddVal.AttachedStructure.StructureId != r.structure.StructureId { - r.logger.Infow("structure updated", "structureID", ddVal.AttachedStructure.StructureId, "extSeq", extSeq, "extFN", extFN, "descriptor", ddVal.String()) + r.logger.Debugw("structure updated", "structureID", ddVal.AttachedStructure.StructureId, "extSeq", extSeq, "extFN", extFN, "descriptor", ddVal.String()) } r.structure = ddVal.AttachedStructure r.decodeTargets = ProcessFrameDependencyStructure(ddVal.AttachedStructure) diff --git a/pkg/sfu/videolayerselector/dependencydescriptor.go b/pkg/sfu/videolayerselector/dependencydescriptor.go index 3c091160e..9adc54b87 100644 --- a/pkg/sfu/videolayerselector/dependencydescriptor.go +++ b/pkg/sfu/videolayerselector/dependencydescriptor.go @@ -111,8 +111,7 @@ func (d *DependencyDescriptor) Select(extPkt *buffer.ExtPacket, _layer int32) (r } if ddwdt.StructureUpdated { - // TODO-REMOVE: remove this log after stable - d.logger.Infow("update dependency structure", + d.logger.Debugw("update dependency structure", "structureID", dd.AttachedStructure.StructureId, "structure", dd.AttachedStructure, "decodeTargets", ddwdt.DecodeTargets, @@ -127,8 +126,7 @@ func (d *DependencyDescriptor) Select(extPkt *buffer.ExtPacket, _layer int32) (r if ddwdt.ExtKeyFrameNum != d.extKeyFrameNum { // keyframe mismatch, drop and reset chains - // TODO-REMOVE: remove this log after stable - d.logger.Infow("drop packet for keyframe mismatch", "incoming", incomingLayer, "efn", extFrameNum, "sn", extPkt.Packet.SequenceNumber, "requiredKeyFrame", ddwdt.ExtKeyFrameNum, "structureKeyFrame", d.extKeyFrameNum) + d.logger.Debugw("drop packet for keyframe mismatch", "incoming", incomingLayer, "efn", extFrameNum, "sn", extPkt.Packet.SequenceNumber, "requiredKeyFrame", ddwdt.ExtKeyFrameNum, "structureKeyFrame", d.extKeyFrameNum) d.decisions.AddDropped(extFrameNum) d.invalidateKeyFrame() return @@ -138,9 +136,8 @@ func (d *DependencyDescriptor) Select(extPkt *buffer.ExtPacket, _layer int32) (r d.updateActiveDecodeTargets(*dd.ActiveDecodeTargetsBitmask) } - // TODO-REMOVE: remove this log after stable if len(fd.ChainDiffs) != len(d.chains) { - d.logger.Warnw("frame chain diff length mismatch", nil, + d.logger.Debugw("frame chain diff length mismatch", nil, "incoming", incomingLayer, "efn", extFrameNum, "sn", extPkt.Packet.SequenceNumber, @@ -255,7 +252,7 @@ func (d *DependencyDescriptor) Select(extPkt *buffer.ExtPacket, _layer int32) (r result.IsSwitching = true if !d.currentLayer.IsValid() { result.IsResuming = true - d.logger.Infow( + d.logger.Debugw( "resuming at layer", "current", incomingLayer, "target", d.targetLayer,