From 21b42fa6d9f8f60d7d548f282a50ae58b1d0da55 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Sat, 30 Aug 2025 17:34:44 +0530 Subject: [PATCH] Do not advertise NACK for RED. (#3889) Set the transceiver codecs first in single peer connection mode and then do audio specific config so that NACK is removed for RED. --- pkg/rtc/transport.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/rtc/transport.go b/pkg/rtc/transport.go index c3f89e60c..6b4e56acc 100644 --- a/pkg/rtc/transport.go +++ b/pkg/rtc/transport.go @@ -955,10 +955,10 @@ func (t *PCTransport) AddTrack( return } + configureTransceiverCodecs(transceiver, enabledCodecs, rtcpFeedbackConfig, !t.params.IsOfferer) if trackLocal.Kind() == webrtc.RTPCodecTypeAudio { configureAudioTransceiver(transceiver, params.Stereo, !params.Red || !t.params.ClientInfo.SupportsAudioRED()) } - configureTransceiverCodecs(transceiver, enabledCodecs, rtcpFeedbackConfig, !t.params.IsOfferer) t.adjustNumOutstandingMedia(transceiver) return } @@ -980,10 +980,10 @@ func (t *PCTransport) AddTransceiverFromTrack( return } + configureTransceiverCodecs(transceiver, enabledCodecs, rtcpFeedbackConfig, !t.params.IsOfferer) if trackLocal.Kind() == webrtc.RTPCodecTypeAudio { configureAudioTransceiver(transceiver, params.Stereo, !params.Red || !t.params.ClientInfo.SupportsAudioRED()) } - configureTransceiverCodecs(transceiver, enabledCodecs, rtcpFeedbackConfig, !t.params.IsOfferer) t.adjustNumOutstandingMedia(transceiver) return }