From 2299a493de0b686b9b7f1b45fa7097984f0da0c9 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Fri, 1 Dec 2023 12:42:12 +0530 Subject: [PATCH] Throttle DD parse logs (#2281) --- pkg/sfu/buffer/dependencydescriptorparser.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/sfu/buffer/dependencydescriptorparser.go b/pkg/sfu/buffer/dependencydescriptorparser.go index 5b2744716..da79c301b 100644 --- a/pkg/sfu/buffer/dependencydescriptorparser.go +++ b/pkg/sfu/buffer/dependencydescriptorparser.go @@ -19,6 +19,7 @@ import ( "sort" "github.com/pion/rtp" + "go.uber.org/atomic" dd "github.com/livekit/livekit-server/pkg/sfu/dependencydescriptor" "github.com/livekit/livekit-server/pkg/sfu/utils" @@ -44,6 +45,8 @@ type DependencyDescriptorParser struct { activeDecodeTargetsExtSeq uint64 activeDecodeTargetsMask uint32 frameChecker *FrameIntegrityChecker + + ddNotFoundCount atomic.Uint32 } func NewDependencyDescriptorParser(ddExtID uint8, logger logger.Logger, onMaxLayerChanged func(int32, int32)) *DependencyDescriptorParser { @@ -73,7 +76,10 @@ func (r *DependencyDescriptorParser) Parse(pkt *rtp.Packet) (*ExtDependencyDescr var videoLayer VideoLayer ddBuf := pkt.GetExtension(r.ddExtID) if ddBuf == nil { - r.logger.Warnw("dependency descriptor extension is not present", nil, "seq", pkt.SequenceNumber) + ddNotFoundCount := r.ddNotFoundCount.Inc() + if ddNotFoundCount%100 == 0 { + r.logger.Warnw("dependency descriptor extension is not present", nil, "seq", pkt.SequenceNumber, "count", ddNotFoundCount) + } return nil, videoLayer, nil }