From 31b042ddce17d4c498d0afdf6021d91a2eaf76ca Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Mon, 9 Oct 2023 14:32:10 +0530 Subject: [PATCH] Log larga negative gap. (#2138) Seeing a large positive gap which I am not able to explain. Wondering if at some other time, a large negative is happening and the large positive is just a correction. --- pkg/sfu/buffer/rtpstats_receiver.go | 3 +++ pkg/sfu/buffer/rtpstats_sender.go | 3 +++ 2 files changed, 6 insertions(+) diff --git a/pkg/sfu/buffer/rtpstats_receiver.go b/pkg/sfu/buffer/rtpstats_receiver.go index 74232a2b5..04e4a311b 100644 --- a/pkg/sfu/buffer/rtpstats_receiver.go +++ b/pkg/sfu/buffer/rtpstats_receiver.go @@ -150,6 +150,9 @@ func (r *RTPStatsReceiver) Update( return } } + if gapSN <= cNumSequenceNumbers { + r.logger.Warnw("large sequence number gap negative", nil, "prev", resSN.PreExtendedHighest, "curr", resSN.ExtendedVal, "gap", gapSN) + } if gapSN != 0 { r.packetsOutOfOrder++ diff --git a/pkg/sfu/buffer/rtpstats_sender.go b/pkg/sfu/buffer/rtpstats_sender.go index 855876f72..4a50e3b14 100644 --- a/pkg/sfu/buffer/rtpstats_sender.go +++ b/pkg/sfu/buffer/rtpstats_sender.go @@ -281,6 +281,9 @@ func (r *RTPStatsSender) Update( // do not start on a padding only packet return } + if gapSN <= cNumSequenceNumbers { + r.logger.Warnw("large sequence number gap negative", nil, "prev", r.extHighestSN, "curr", extSequenceNumber, "gap", gapSN) + } if extSequenceNumber < r.extStartSN { r.packetsLost += r.extStartSN - extSequenceNumber