From 31b4148052df70c70284e488d2ad3b7b18f29c03 Mon Sep 17 00:00:00 2001 From: David Colburn Date: Mon, 21 Jun 2021 15:54:42 -0700 Subject: [PATCH] don't send empty pkts --- pkg/rtc/participant.go | 8 +++++--- pkg/service/wire_gen.go | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/pkg/rtc/participant.go b/pkg/rtc/participant.go index 1e1889a05..281fcca74 100644 --- a/pkg/rtc/participant.go +++ b/pkg/rtc/participant.go @@ -961,9 +961,11 @@ func (p *ParticipantImpl) rtcpSendWorker() { }) } - if err := p.publisher.pc.WriteRTCP(fwdPkts); err != nil { - logger.Errorw("could not write RTCP to participant", err, - "participant", p.Identity()) + if len(fwdPkts) > 0 { + if err := p.publisher.pc.WriteRTCP(fwdPkts); err != nil { + logger.Errorw("could not write RTCP to participant", err, + "participant", p.Identity()) + } } } } diff --git a/pkg/service/wire_gen.go b/pkg/service/wire_gen.go index c7bddcffb..62d017ed7 100644 --- a/pkg/service/wire_gen.go +++ b/pkg/service/wire_gen.go @@ -1,6 +1,6 @@ // Code generated by Wire. DO NOT EDIT. -//go:generate wire +//go:generate go run github.com/google/wire/cmd/wire //+build !wireinject package service