From 48b2ea11c100a81652410e24e205d8ccbe238163 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Sat, 8 Apr 2023 13:41:17 +0530 Subject: [PATCH] Forgot to transfer ddBytes (#1592) --- pkg/sfu/downtrack.go | 2 +- pkg/sfu/forwarder.go | 1 + pkg/sfu/receiver.go | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/sfu/downtrack.go b/pkg/sfu/downtrack.go index 4043ccd19..ccd68e5ca 100644 --- a/pkg/sfu/downtrack.go +++ b/pkg/sfu/downtrack.go @@ -492,7 +492,7 @@ func (d *DownTrack) maybeStartKeyFrameRequester() { // d.stopKeyFrameRequester() - // TODO : for svc, don't need pli/lrr when layer comes down + // SVC-TODO : don't need pli/lrr when layer comes down locked, layer := d.forwarder.CheckSync() if !locked { go d.keyFrameRequester(d.keyFrameRequestGeneration.Load(), layer) diff --git a/pkg/sfu/forwarder.go b/pkg/sfu/forwarder.go index de689e8dd..8d75db2f9 100644 --- a/pkg/sfu/forwarder.go +++ b/pkg/sfu/forwarder.go @@ -1490,6 +1490,7 @@ func (f *Forwarder) getTranslationParamsVideo(extPkt *buffer.ExtPacket, layer in tp.isSwitchingToMaxLayer = result.IsSwitchingToMaxSpatial tp.isResuming = result.IsResuming tp.marker = result.RTPMarker + tp.ddBytes = result.DependencyDescriptorExtension if FlagPauseOnDowngrade && f.isDeficientLocked() && f.vls.GetTarget().Spatial < f.vls.GetCurrent().Spatial { // diff --git a/pkg/sfu/receiver.go b/pkg/sfu/receiver.go index 3d2cc9c31..0868a574e 100644 --- a/pkg/sfu/receiver.go +++ b/pkg/sfu/receiver.go @@ -484,7 +484,7 @@ func (w *WebRTCReceiver) sendRTCP(packets []rtcp.Packet) { } func (w *WebRTCReceiver) SendPLI(layer int32, force bool) { - // TODO : should send LRR (Layer Refresh Request) instead of PLI + // SVC-TODO : should send LRR (Layer Refresh Request) instead of PLI buff := w.getBuffer(layer) if buff == nil { return