Consolidate operations on LocalNode. (#3140)

pkg/routing/node.go

@@ -16,33 +16,146 @@ package routing
 
 import (
 	"runtime"
+	"sync"
 	"time"
 
 	"github.com/livekit/protocol/livekit"
+	"github.com/livekit/protocol/logger"
 	"github.com/livekit/protocol/utils"
 	"github.com/livekit/protocol/utils/guid"
 
 	"github.com/livekit/livekit-server/pkg/config"
+	"github.com/livekit/livekit-server/pkg/telemetry/prometheus"
 )
 
-type LocalNode *livekit.Node
+type LocalNode interface {
+	Clone() *livekit.Node
+	SetNodeID(nodeID livekit.NodeID)
+	NodeID() livekit.NodeID
+	NodeType() livekit.NodeType
+	NodeIP() string
+	Region() string
+	SetState(state livekit.NodeState)
+	SetStats(stats *livekit.NodeStats)
+	UpdateNodeStats() bool
+	SecondsSinceNodeStatsUpdate() float64
+}
 
-func NewLocalNode(conf *config.Config) (LocalNode, error) {
+type LocalNodeImpl struct {
+	lock sync.RWMutex
+	node *livekit.Node
+
+	// previous stats for computing averages
+	prevStats *livekit.NodeStats
+}
+
+func NewLocalNode(conf *config.Config) (*LocalNodeImpl, error) {
 	nodeID := guid.New(utils.NodePrefix)
-	if conf.RTC.NodeIP == "" {
+	if conf != nil && conf.RTC.NodeIP == "" {
 		return nil, ErrIPNotSet
 	}
-	node := &livekit.Node{
-		Id:      nodeID,
-		Ip:      conf.RTC.NodeIP,
-		NumCpus: uint32(runtime.NumCPU()),
-		Region:  conf.Region,
-		State:   livekit.NodeState_SERVING,
-		Stats: &livekit.NodeStats{
-			StartedAt: time.Now().Unix(),
-			UpdatedAt: time.Now().Unix(),
+	l := &LocalNodeImpl{
+		node: &livekit.Node{
+			Id:      nodeID,
+			NumCpus: uint32(runtime.NumCPU()),
+			State:   livekit.NodeState_SERVING,
+			Stats: &livekit.NodeStats{
+				StartedAt: time.Now().Unix(),
+				UpdatedAt: time.Now().Unix(),
+			},
 		},
 	}
-
-	return node, nil
+	if conf != nil {
+		l.node.Ip = conf.RTC.NodeIP
+		l.node.Region = conf.Region
+	}
+	return l, nil
+}
+
+func NewLocalNodeFromNodeProto(node *livekit.Node) (*LocalNodeImpl, error) {
+	return &LocalNodeImpl{node: utils.CloneProto(node)}, nil
+}
+
+func (l *LocalNodeImpl) Clone() *livekit.Node {
+	l.lock.RLock()
+	defer l.lock.RUnlock()
+
+	return utils.CloneProto(l.node)
+}
+
+// for testing only
+func (l *LocalNodeImpl) SetNodeID(nodeID livekit.NodeID) {
+	l.lock.Lock()
+	defer l.lock.Unlock()
+
+	l.node.Id = string(nodeID)
+}
+
+func (l *LocalNodeImpl) NodeID() livekit.NodeID {
+	l.lock.RLock()
+	defer l.lock.RUnlock()
+
+	return livekit.NodeID(l.node.Id)
+}
+
+func (l *LocalNodeImpl) NodeType() livekit.NodeType {
+	l.lock.RLock()
+	defer l.lock.RUnlock()
+
+	return l.node.Type
+}
+
+func (l *LocalNodeImpl) NodeIP() string {
+	l.lock.RLock()
+	defer l.lock.RUnlock()
+
+	return l.node.Ip
+}
+
+func (l *LocalNodeImpl) Region() string {
+	l.lock.RLock()
+	defer l.lock.RUnlock()
+
+	return l.node.Region
+}
+
+func (l *LocalNodeImpl) SetState(state livekit.NodeState) {
+	l.lock.Lock()
+	defer l.lock.Unlock()
+
+	l.node.State = state
+}
+
+// for testing only
+func (l *LocalNodeImpl) SetStats(stats *livekit.NodeStats) {
+	l.lock.Lock()
+	defer l.lock.Unlock()
+
+	l.node.Stats = utils.CloneProto(stats)
+}
+
+func (l *LocalNodeImpl) UpdateNodeStats() bool {
+	l.lock.Lock()
+	defer l.lock.Unlock()
+
+	if l.prevStats == nil {
+		l.prevStats = l.node.Stats
+	}
+	updated, computedAvg, err := prometheus.GetUpdatedNodeStats(l.node.Stats, l.prevStats)
+	if err != nil {
+		logger.Errorw("could not update node stats", err)
+		return false
+	}
+	l.node.Stats = updated
+	if computedAvg {
+		l.prevStats = updated
+	}
+	return true
+}
+
+func (l *LocalNodeImpl) SecondsSinceNodeStatsUpdate() float64 {
+	l.lock.RLock()
+	defer l.lock.RUnlock()
+
+	return time.Since(time.Unix(0, l.node.Stats.UpdatedAt)).Seconds()
 }