From 4a7b1e8587f8b8c4fd4a0c772209fd3b305ffe76 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Fri, 15 May 2026 12:45:51 +0530 Subject: [PATCH] Create NACK tracker only once. (#4527) Not a major issue, but just avoiding duplicate creation of NACK module. RTCP feedback of `nack` and `nack pli` end up getting treated as `nack` and was double creating. --- pkg/sfu/buffer/buffer_base.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/sfu/buffer/buffer_base.go b/pkg/sfu/buffer/buffer_base.go index 241950a5a..a7f0ef8b0 100644 --- a/pkg/sfu/buffer/buffer_base.go +++ b/pkg/sfu/buffer/buffer_base.go @@ -387,7 +387,9 @@ func (b *BufferBase) BindLocked(rtpParameters webrtc.RTPParameters, codec webrtc } b.logger.Debugw("Setting feedback", "type", webrtc.TypeRTCPFBNACK) - b.nacker = nack.NewNACKQueue(nack.NackQueueParamsDefault) + if b.nacker == nil { + b.nacker = nack.NewNACKQueue(nack.NackQueueParamsDefault) + } } }