From 4d7839bff3bbcd5b124f227503e0123060ab4b30 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Tue, 1 Oct 2024 00:33:36 +0530 Subject: [PATCH] Fix clock rate skew calculation. (#3055) Cannot cast NTP timestamp diff to time.Duration. That causes duration to appear more than it actually is. Was causing a bunch of log spam. --- pkg/sfu/buffer/rtpstats_receiver.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/sfu/buffer/rtpstats_receiver.go b/pkg/sfu/buffer/rtpstats_receiver.go index 504de9b3b..eb03b495a 100644 --- a/pkg/sfu/buffer/rtpstats_receiver.go +++ b/pkg/sfu/buffer/rtpstats_receiver.go @@ -443,11 +443,11 @@ func (r *RTPStatsReceiver) checkRTPClockSkewForSenderReport(srData *livekit.RTCP return } - timeSinceLast := time.Duration(srData.NtpTimestamp - r.srNewest.NtpTimestamp).Seconds() + timeSinceLast := mediatransportutil.NtpTime(srData.NtpTimestamp).Time().Sub(mediatransportutil.NtpTime(r.srNewest.NtpTimestamp).Time()).Seconds() rtpDiffSinceLast := srData.RtpTimestampExt - r.srNewest.RtpTimestampExt calculatedClockRateFromLast := float64(rtpDiffSinceLast) / timeSinceLast - timeSinceFirst := time.Duration(srData.NtpTimestamp - r.srFirst.NtpTimestamp).Seconds() + timeSinceFirst := mediatransportutil.NtpTime(srData.NtpTimestamp).Time().Sub(mediatransportutil.NtpTime(r.srFirst.NtpTimestamp).Time()).Seconds() rtpDiffSinceFirst := srData.RtpTimestampExt - r.srFirst.RtpTimestampExt calculatedClockRateFromFirst := float64(rtpDiffSinceFirst) / timeSinceFirst