From 540d1c2e8c8a71fa2401f006efd81c8a1ae15342 Mon Sep 17 00:00:00 2001 From: David Zhao Date: Fri, 16 Apr 2021 00:39:22 -0700 Subject: [PATCH] always allow ICE candidates, even before offer --- pkg/service/roommanager.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pkg/service/roommanager.go b/pkg/service/roommanager.go index 7b4d98f43..fb327efc5 100644 --- a/pkg/service/roommanager.go +++ b/pkg/service/roommanager.go @@ -321,12 +321,6 @@ func (r *RoomManager) rtcSessionWorker(room *rtc.Room, participant types.Partici return } case *livekit.SignalRequest_Trickle: - if participant.State() == livekit.ParticipantInfo_JOINING { - logger.Errorw("cannot trickle before offer", "participant", participant.Identity()) - //conn.WriteJSON(jsonError(http.StatusNotAcceptable, "cannot trickle before peer offer")) - return - } - candidateInit := rtc.FromProtoTrickle(msg.Trickle) //logger.Debugw("adding peer candidate", "participant", participant.ID()) if err := participant.AddICECandidate(candidateInit, msg.Trickle.Target); err != nil {