From 55718724a9d71eb7ff3cc6470d70fe889c81547a Mon Sep 17 00:00:00 2001
From: Raja Subramanian <raja.gobi@tutanota.com>
Date: Sat, 26 Nov 2022 01:05:29 +0530
Subject: [PATCH] Check forwarder started when seeing. (#1191)

When switching from local -> remote or remote -> local,
the forwarder state is cached and restored after the switch
to ensure continuity in sequence number /time stamp.
But, if the forwarder had not started before the switch,
the sequence number always starts at 1 because of seeding.
So, do not see unless forwarder was started before the switch.
---
 pkg/sfu/buffer/rtpstats.go |  2 +-
 pkg/sfu/forwarder.go       | 14 ++++++++++++--
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/pkg/sfu/buffer/rtpstats.go b/pkg/sfu/buffer/rtpstats.go
index 200ab8c97..614eac2a1 100644
--- a/pkg/sfu/buffer/rtpstats.go
+++ b/pkg/sfu/buffer/rtpstats.go
@@ -179,7 +179,7 @@ func (r *RTPStats) Seed(from *RTPStats) {
 	r.lock.Lock()
 	defer r.lock.Unlock()
 
-	if from == nil {
+	if from == nil || !from.initialized {
 		return
 	}
 
diff --git a/pkg/sfu/forwarder.go b/pkg/sfu/forwarder.go
index 978c07c26..255d189a7 100644
--- a/pkg/sfu/forwarder.go
+++ b/pkg/sfu/forwarder.go
@@ -171,14 +171,15 @@ var (
 // -------------------------------------------------------------------
 
 type ForwarderState struct {
+	Started    bool
 	LastTSCalc int64
 	RTP        RTPMungerState
 	VP8        VP8MungerState
 }
 
 func (f ForwarderState) String() string {
-	return fmt.Sprintf("ForwarderState{lTSCalc: %d, rtp: %s, vp8: %s}",
-		f.LastTSCalc, f.RTP.String(), f.VP8.String())
+	return fmt.Sprintf("ForwarderState{started: %v, lTSCalc: %d, rtp: %s, vp8: %s}",
+		f.Started, f.LastTSCalc, f.RTP.String(), f.VP8.String())
 }
 
 // -------------------------------------------------------------------
@@ -261,7 +262,12 @@ func (f *Forwarder) GetState() ForwarderState {
 	f.lock.RLock()
 	defer f.lock.RUnlock()
 
+	if !f.started {
+		return ForwarderState{}
+	}
+
 	state := ForwarderState{
+		Started:    f.started,
 		LastTSCalc: f.lTSCalc,
 		RTP:        f.rtpMunger.GetLast(),
 	}
@@ -274,6 +280,10 @@ func (f *Forwarder) GetState() ForwarderState {
 }
 
 func (f *Forwarder) SeedState(state ForwarderState) {
+	if !state.Started {
+		return
+	}
+
 	f.lock.Lock()
 	defer f.lock.Unlock()