From 5aa093f65dda0761de16ed2e36baa76d3bdf5c1a Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Thu, 5 Oct 2023 12:02:55 +0530 Subject: [PATCH] Log time when there are too many packets. (#2127) Ideally, can remove the nil return when there are too many packets as we have more information with extended sequence numbers, but logging duration first to understand what is happening better. --- pkg/sfu/buffer/rtpstats_base.go | 9 +++++++-- pkg/sfu/buffer/rtpstats_sender.go | 9 +++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/pkg/sfu/buffer/rtpstats_base.go b/pkg/sfu/buffer/rtpstats_base.go index 7438c9c72..6cf0fe6eb 100644 --- a/pkg/sfu/buffer/rtpstats_base.go +++ b/pkg/sfu/buffer/rtpstats_base.go @@ -531,8 +531,13 @@ func (r *rtpStatsBase) deltaInfo(snapshotID uint32, extStartSN uint64, extHighes packetsExpected := now.extStartSN - then.extStartSN if packetsExpected > cNumSequenceNumbers { r.logger.Errorw( - "too many packets expected in delta", - fmt.Errorf("start: %d, end: %d, expected: %d", then.extStartSN, now.extStartSN, packetsExpected), + "too many packets expected in delta", nil, + "startSN", then.extStartSN, + "endSN", now.extStartSN, + "packetsExpected", packetsExpected, + "startTime", startTime, + "endTime", endTime, + "duration", endTime.Sub(startTime), ) return nil } diff --git a/pkg/sfu/buffer/rtpstats_sender.go b/pkg/sfu/buffer/rtpstats_sender.go index df6dd6768..73adc894a 100644 --- a/pkg/sfu/buffer/rtpstats_sender.go +++ b/pkg/sfu/buffer/rtpstats_sender.go @@ -600,8 +600,13 @@ func (r *RTPStatsSender) DeltaInfoSender(senderSnapshotID uint32) *RTPDeltaInfo packetsExpected := uint32(now.extStartSN - then.extStartSN) if packetsExpected > cNumSequenceNumbers { r.logger.Warnw( - "too many packets expected in delta (sender)", - fmt.Errorf("start: %d, end: %d, expected: %d", then.extStartSN, now.extStartSN, packetsExpected), + "too many packets expected in delta (sender)", nil, + "startSN", then.extStartSN, + "endSN", now.extStartSN, + "packetsExpected", packetsExpected, + "startTime", startTime, + "endTime", endTime, + "duration", endTime.Sub(startTime), ) return nil }