From 60297b24fd86e7d101dae8307da61724e28edfbe Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Thu, 15 Sep 2022 19:17:24 +0530 Subject: [PATCH] Use UnixMilli (#1009) * Use UnixMilli * enhance comment --- pkg/service/rtcservice.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/service/rtcservice.go b/pkg/service/rtcservice.go index 7919c8ce7..0e44518fa 100644 --- a/pkg/service/rtcservice.go +++ b/pkg/service/rtcservice.go @@ -288,7 +288,11 @@ func (s *RTCService) ServeHTTP(w http.ResponseWriter, r *http.Request) { if _, ok := req.Message.(*livekit.SignalRequest_Ping); ok { _ = sigConn.WriteResponse(&livekit.SignalResponse{ Message: &livekit.SignalResponse_Pong{ - Pong: time.Now().UnixNano(), + // + // Although this field is int64, some clients (like JS) cause overflow if nanosecond granularity is used. + // So. use UnixMillis(). + // + Pong: time.Now().UnixMilli(), }, }) continue