From 60347fc64caf846a25468279dca95f34bf12ab8c Mon Sep 17 00:00:00 2001
From: cnderrauber <zengjie9004@gmail.com>
Date: Thu, 26 Oct 2023 13:50:37 +0800
Subject: [PATCH] Disable H.264 for android firefox

---
 pkg/clientconfiguration/conf.go      | 3 ++-
 pkg/clientconfiguration/conf_test.go | 4 +++-
 pkg/clientconfiguration/match.go     | 9 +++++----
 pkg/rtc/clientinfo.go                | 8 ++++++--
 4 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/pkg/clientconfiguration/conf.go b/pkg/clientconfiguration/conf.go
index 8c37b7ba4..8348a1d1e 100644
--- a/pkg/clientconfiguration/conf.go
+++ b/pkg/clientconfiguration/conf.go
@@ -33,7 +33,8 @@ var StaticConfigurations = []ConfigurationItem{
 	// 	Merge: false,
 	// },
 	{
-		Match: &ScriptMatch{Expr: `c.device_model == "Xiaomi 2201117TI" && c.os == "android"`},
+		Match: &ScriptMatch{Expr: `(c.device_model == "xiaomi 2201117ti" && c.os == "android) ||
+		  ((c.browser == "firefox" || c.browser == "firefox mobile") && (c.os == "linux" || c.os == "android"))`},
 		Configuration: &livekit.ClientConfiguration{
 			DisabledCodecs: &livekit.DisabledCodecs{
 				Publish: []*livekit.Codec{{Mime: "video/h264"}},
diff --git a/pkg/clientconfiguration/conf_test.go b/pkg/clientconfiguration/conf_test.go
index 093a98f19..947766e3e 100644
--- a/pkg/clientconfiguration/conf_test.go
+++ b/pkg/clientconfiguration/conf_test.go
@@ -98,7 +98,9 @@ func TestScriptMatch(t *testing.T) {
 		{name: "simple match", expr: `c.protocol > 5`, result: true},
 		{name: "invalid expr", expr: `cc.protocol > 5`, err: true},
 		{name: "unexist field", expr: `c.protocols > 5`, err: true},
-		{name: "combined condition", expr: `c.protocol > 5 && (c.sdk=="ANDROID" || c.sdk=="IOS")`, result: true},
+		{name: "combined condition", expr: `c.protocol > 5 && (c.sdk=="android" || c.sdk=="ios")`, result: true},
+		{name: "combined condition2", expr: `(c.device_model == "xiaomi 2201117ti" && c.os == "android) ||
+		  ((c.browser == "firefox" || c.browser == "firefox mobile") && (c.os == "linux" || c.os == "android"))`, result: false},
 	}
 
 	for _, c := range cases {
diff --git a/pkg/clientconfiguration/match.go b/pkg/clientconfiguration/match.go
index 3c3514220..b915c2c6a 100644
--- a/pkg/clientconfiguration/match.go
+++ b/pkg/clientconfiguration/match.go
@@ -17,6 +17,7 @@ package clientconfiguration
 import (
 	"context"
 	"errors"
+	"strings"
 
 	"github.com/d5/tengo/v2"
 
@@ -69,19 +70,19 @@ func (c *clientObject) IndexGet(index tengo.Object) (res tengo.Object, err error
 
 	switch field.Value {
 	case "sdk":
-		return &tengo.String{Value: c.info.Sdk.String()}, nil
+		return &tengo.String{Value: strings.ToLower(c.info.Sdk.String())}, nil
 	case "version":
 		return &tengo.String{Value: c.info.Version}, nil
 	case "protocol":
 		return &tengo.Int{Value: int64(c.info.Protocol)}, nil
 	case "os":
-		return &tengo.String{Value: c.info.Os}, nil
+		return &tengo.String{Value: strings.ToLower(c.info.Os)}, nil
 	case "os_version":
 		return &tengo.String{Value: c.info.OsVersion}, nil
 	case "device_model":
-		return &tengo.String{Value: c.info.DeviceModel}, nil
+		return &tengo.String{Value: strings.ToLower(c.info.DeviceModel)}, nil
 	case "browser":
-		return &tengo.String{Value: c.info.Browser}, nil
+		return &tengo.String{Value: strings.ToLower(c.info.Browser)}, nil
 	case "browser_version":
 		return &tengo.String{Value: c.info.BrowserVersion}, nil
 	case "address":
diff --git a/pkg/rtc/clientinfo.go b/pkg/rtc/clientinfo.go
index 62117e0d1..ca85ec583 100644
--- a/pkg/rtc/clientinfo.go
+++ b/pkg/rtc/clientinfo.go
@@ -26,7 +26,7 @@ type ClientInfo struct {
 }
 
 func (c ClientInfo) isFirefox() bool {
-	return c.ClientInfo != nil && strings.EqualFold(c.ClientInfo.Browser, "firefox")
+	return c.ClientInfo != nil && (strings.EqualFold(c.ClientInfo.Browser, "firefox") || strings.EqualFold(c.ClientInfo.Browser, "firefox mobile"))
 }
 
 func (c ClientInfo) isSafari() bool {
@@ -41,6 +41,10 @@ func (c ClientInfo) isLinux() bool {
 	return c.ClientInfo != nil && strings.EqualFold(c.ClientInfo.Os, "linux")
 }
 
+func (c ClientInfo) isAndroid() bool {
+	return c.ClientInfo != nil && strings.EqualFold(c.ClientInfo.Os, "android")
+}
+
 func (c ClientInfo) SupportsAudioRED() bool {
 	return !c.isFirefox() && !c.isSafari()
 }
@@ -85,7 +89,7 @@ func (c ClientInfo) SupportsChangeRTPSenderEncodingActive() bool {
 }
 
 func (c ClientInfo) ComplyWithCodecOrderInSDPAnswer() bool {
-	return !(c.isLinux() && c.isFirefox())
+	return !((c.isLinux() || c.isAndroid()) && c.isFirefox())
 }
 
 // compareVersion compares a semver against the current client SDK version