From 76bc112649bb1cd5cb72ba77bb954655a969c068 Mon Sep 17 00:00:00 2001 From: cnderrauber Date: Fri, 11 Oct 2024 06:59:54 +0000 Subject: [PATCH] Don't return bind error on unsupport codec (#3085) pion will not start transports if Bind fails at first answer --- pkg/sfu/downtrack.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/sfu/downtrack.go b/pkg/sfu/downtrack.go index b2b3a5095..c0bbaef2a 100644 --- a/pkg/sfu/downtrack.go +++ b/pkg/sfu/downtrack.go @@ -444,7 +444,8 @@ func (d *DownTrack) Bind(t webrtc.TrackLocalContext) (webrtc.RTPCodecParameters, if onBinding != nil { onBinding(err) } - return webrtc.RTPCodecParameters{}, err + // don't return error here, as pion will not start transports if Bind fails at first answer + return webrtc.RTPCodecParameters{}, nil } // if a downtrack is closed before bind, it already unsubscribed from client, don't do subsequent operation and return here.