From 7c830ea5b951f6de9a76b34840ea88cafa4dbdb9 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Thu, 19 Oct 2023 00:53:50 +0530 Subject: [PATCH] Log highest time update on padding packet. (#2154) * Log highest time update on padding packet. Seeing a strange case of what looks like highest time getting updated on a padding packet. Can't see how it happens in code. So, logging to check. Will be removing log after checking. * log sequence number also --- pkg/sfu/buffer/rtpstats_sender.go | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/pkg/sfu/buffer/rtpstats_sender.go b/pkg/sfu/buffer/rtpstats_sender.go index 2ac196904..c6cd98dd2 100644 --- a/pkg/sfu/buffer/rtpstats_sender.go +++ b/pkg/sfu/buffer/rtpstats_sender.go @@ -380,6 +380,17 @@ func (r *RTPStatsSender) Update( if extTimestamp != r.extHighestTS { // update only on first packet as same timestamp could be in multiple packets. // NOTE: this may not be the first packet with this time stamp if there is packet loss. + if payloadSize == 0 { + r.logger.Infow( + "updating highest time on padding packet", + "extSequenceNumber", extSequenceNumber, + "extHighestSN", r.extHighestSN, + "extTimestamp", extTimestamp, + "extHighestTS", r.extHighestTS, + "highestTime", r.highestTime.String(), + "packetTime", packetTime.String(), + ) + } r.highestTime = packetTime } r.extHighestSN = extSequenceNumber