From 7f4ead9b25bdfff6cd939ad80c0d17178b5a3b3d Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Fri, 21 Jan 2022 11:16:54 +0530 Subject: [PATCH] Fire onNoSubscribers callback in only one place. (#360) While reworking some cloud code, this is getting fired multiple times (in RemoveAllSubscriber and in the callback). So, it causes some errors in the logs. Fire it only from one place. --- pkg/rtc/mediatracksubscriptions.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pkg/rtc/mediatracksubscriptions.go b/pkg/rtc/mediatracksubscriptions.go index 1f7d355ec..9b960a01b 100644 --- a/pkg/rtc/mediatracksubscriptions.go +++ b/pkg/rtc/mediatracksubscriptions.go @@ -263,8 +263,6 @@ func (t *MediaTrackSubscriptions) RemoveSubscriber(participantID livekit.Partici if subTrack != nil { subTrack.DownTrack().CloseWithFlush(!resume) } - - t.maybeNotifyNoSubscribers() } func (t *MediaTrackSubscriptions) RemoveAllSubscribers() { @@ -278,8 +276,6 @@ func (t *MediaTrackSubscriptions) RemoveAllSubscribers() { for _, subTrack := range subscribedTracks { subTrack.DownTrack().Close() } - - t.maybeNotifyNoSubscribers() } func (t *MediaTrackSubscriptions) RevokeDisallowedSubscribers(allowedSubscriberIDs []livekit.ParticipantID) []livekit.ParticipantID {