From 85c678c7f05cda6e5de50678a25c80dc6cdf6903 Mon Sep 17 00:00:00 2001 From: David Zhao Date: Mon, 26 Oct 2026 12:46:38 -0700 Subject: [PATCH] fix flaky TestAgentNamespaces (#5074) causing a few race failures in CI --- test/agent_test.go | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/test/agent_test.go b/test/agent_test.go index 9b3145281..67eab78b5 100644 --- a/test/agent_test.go +++ b/test/agent_test.go @@ -140,6 +140,15 @@ func TestAgentNamespaces(t *testing.T) { ac1.Run(livekit.JobType_JT_ROOM, "namespace1") ac2.Run(livekit.JobType_JT_ROOM, "namespace2") + testutils.WithTimeout(t, func() string { + if ac1.registered.Load() != 1 || ac2.registered.Load() != 1 { + return "worker not registered" + } + return "" + }, RegisterTimeout) + + // a job goes only to the namespaces the server knows of when it + // dispatches the job, so the room is created once both have registered _, err = roomClient.CreateRoom(contextWithToken(createRoomToken()), &livekit.CreateRoomRequest{ Name: testRoom, Agents: []*livekit.RoomAgentDispatch{ @@ -151,13 +160,6 @@ func TestAgentNamespaces(t *testing.T) { }) require.NoError(t, err) - testutils.WithTimeout(t, func() string { - if ac1.registered.Load() != 1 || ac2.registered.Load() != 1 { - return "worker not registered" - } - return "" - }, RegisterTimeout) - c1 := createRTCClient("c1", defaultServerPort, testRTCServicePath, nil) waitUntilConnected(t, c1)