From 87e2b2366e5f6a2c01c4ed6196ecddc8a39bfd2a Mon Sep 17 00:00:00 2001 From: Paul Wells Date: Tue, 2 May 2023 08:31:12 -0700 Subject: [PATCH] reduce log level of signal close errors (#1675) * reduce log level of signal close errors * update psrpc * cleanup * cleanup --- go.mod | 4 ++-- go.sum | 8 ++++---- pkg/rtc/participant_signal.go | 8 +++++++- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/go.mod b/go.mod index 11dff2106..b6292142b 100644 --- a/go.mod +++ b/go.mod @@ -19,7 +19,7 @@ require ( github.com/livekit/mageutil v0.0.0-20230125210925-54e8a70427c1 github.com/livekit/mediatransportutil v0.0.0-20230326055817-ed569ca13d26 github.com/livekit/protocol v1.5.6-0.20230428011359-db5afb1c7f9b - github.com/livekit/psrpc v0.3.1-0.20230425025640-5390915734c3 + github.com/livekit/psrpc v0.3.1-0.20230502152150-df9dd21fba11 github.com/mackerelio/go-osstat v0.2.4 github.com/magefile/mage v1.14.0 github.com/maxbrunsfeld/counterfeiter/v6 v6.6.1 @@ -37,7 +37,7 @@ require ( github.com/pion/webrtc/v3 v3.2.1 github.com/pkg/errors v0.9.1 github.com/prometheus/client_golang v1.15.0 - github.com/redis/go-redis/v9 v9.0.3 + github.com/redis/go-redis/v9 v9.0.4 github.com/rs/cors v1.9.0 github.com/stretchr/testify v1.8.2 github.com/thoas/go-funk v0.9.3 diff --git a/go.sum b/go.sum index 5d67de0e3..3b4cb4271 100644 --- a/go.sum +++ b/go.sum @@ -123,8 +123,8 @@ github.com/livekit/mediatransportutil v0.0.0-20230326055817-ed569ca13d26 h1:QlQF github.com/livekit/mediatransportutil v0.0.0-20230326055817-ed569ca13d26/go.mod h1:eDA41kiySZoG+wy4Etsjb3w0jjLx69i/vAmSjG4bteA= github.com/livekit/protocol v1.5.6-0.20230428011359-db5afb1c7f9b h1:UEFMJr1OTF0yAX9mRRaQQ/YrTA6H7hCkbuABWfT6wLk= github.com/livekit/protocol v1.5.6-0.20230428011359-db5afb1c7f9b/go.mod h1:MBW05GWdhbl+o6u2gLLCQtDvr9EvcV4VWckpIYtoM2c= -github.com/livekit/psrpc v0.3.1-0.20230425025640-5390915734c3 h1:NXcxrluYLng7LTHcYNOj/MdR4SHWrKQAG2G+U930mTA= -github.com/livekit/psrpc v0.3.1-0.20230425025640-5390915734c3/go.mod h1:n6JntEg+zT6Ji8InoyTpV7wusPNwGqqtxmHlkNhDN0U= +github.com/livekit/psrpc v0.3.1-0.20230502152150-df9dd21fba11 h1:VS23iVQu/TNiLEM5XjbBSY28+B6nSewjKWPDbieg0Ho= +github.com/livekit/psrpc v0.3.1-0.20230502152150-df9dd21fba11/go.mod h1:n6JntEg+zT6Ji8InoyTpV7wusPNwGqqtxmHlkNhDN0U= github.com/mackerelio/go-osstat v0.2.4 h1:qxGbdPkFo65PXOb/F/nhDKpF2nGmGaCFDLXoZjJTtUs= github.com/mackerelio/go-osstat v0.2.4/go.mod h1:Zy+qzGdZs3A9cuIqmgbJvwbmLQH9dJvtio5ZjJTbdlQ= github.com/magefile/mage v1.14.0 h1:6QDX3g6z1YvJ4olPhT1wksUcSa/V0a1B+pJb73fBjyo= @@ -229,8 +229,8 @@ github.com/prometheus/common v0.42.0 h1:EKsfXEYo4JpWMHH5cg+KOUWeuJSov1Id8zGR8eeI github.com/prometheus/common v0.42.0/go.mod h1:xBwqVerjNdUDjgODMpudtOMwlOwf2SaTr1yjz4b7Zbc= github.com/prometheus/procfs v0.9.0 h1:wzCHvIvM5SxWqYvwgVL7yJY8Lz3PKn49KQtpgMYJfhI= github.com/prometheus/procfs v0.9.0/go.mod h1:+pB4zwohETzFnmlpe6yd2lSc+0/46IYZRB/chUwxUZY= -github.com/redis/go-redis/v9 v9.0.3 h1:+7mmR26M0IvyLxGZUHxu4GiBkJkVDid0Un+j4ScYu4k= -github.com/redis/go-redis/v9 v9.0.3/go.mod h1:WqMKv5vnQbRuZstUwxQI195wHy+t4PuXDOjzMvcuQHk= +github.com/redis/go-redis/v9 v9.0.4 h1:FC82T+CHJ/Q/PdyLW++GeCO+Ol59Y4T7R4jbgjvktgc= +github.com/redis/go-redis/v9 v9.0.4/go.mod h1:WqMKv5vnQbRuZstUwxQI195wHy+t4PuXDOjzMvcuQHk= github.com/rogpeppe/go-internal v1.6.1/go.mod h1:xXDCJY+GAPziupqXw64V24skbSoqbTEfhy4qGm1nDQc= github.com/rogpeppe/go-internal v1.9.0 h1:73kH8U+JUqXU8lRuOHeVHaa/SZPifC7BkcraZVejAe8= github.com/rs/cors v1.9.0 h1:l9HGsTsHJcvW14Nk7J9KFz8bzeAWXn3CG6bgt7LsrAE= diff --git a/pkg/rtc/participant_signal.go b/pkg/rtc/participant_signal.go index 106c8370a..e09ff85ab 100644 --- a/pkg/rtc/participant_signal.go +++ b/pkg/rtc/participant_signal.go @@ -1,12 +1,14 @@ package rtc import ( + "errors" "fmt" "time" "github.com/pion/webrtc/v3" "github.com/livekit/protocol/livekit" + "github.com/livekit/psrpc" "github.com/livekit/livekit-server/pkg/routing" ) @@ -265,7 +267,11 @@ func (p *ParticipantImpl) writeMessage(msg *livekit.SignalResponse) error { } err := sink.WriteMessage(msg) - if err != nil { + if errors.Is(err, psrpc.Canceled) { + p.params.Logger.Debugw("could not send message to participant", + "error", err, "messageType", fmt.Sprintf("%T", msg.Message)) + return nil + } else if err != nil { p.params.Logger.Warnw("could not send message to participant", err, "messageType", fmt.Sprintf("%T", msg.Message)) return err