From a55c50f61d80f55eb3a8d57c8e0cc0f9e18ac146 Mon Sep 17 00:00:00 2001
From: Raja Subramanian <raja.gobi@tutanota.com>
Date: Wed, 13 Sep 2023 15:52:10 +0530
Subject: [PATCH] Throttle packet errors/warns a bit. (#2068)

* Throttle packet errors/warns a bit.

In very bad network conditions, it is possible that packets
arrive out-of-order, have choppy behaviour.

Use some counters and temper logs.

* slight change in comment
---
 pkg/sfu/buffer/buffer.go | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/pkg/sfu/buffer/buffer.go b/pkg/sfu/buffer/buffer.go
index d0d009f2e..f27e449a2 100644
--- a/pkg/sfu/buffer/buffer.go
+++ b/pkg/sfu/buffer/buffer.go
@@ -16,6 +16,7 @@ package buffer
 
 import (
 	"encoding/binary"
+	"errors"
 	"io"
 	"strings"
 	"sync"
@@ -120,6 +121,9 @@ type Buffer struct {
 	paused              bool
 	frameRateCalculator [DefaultMaxLayerSpatial + 1]FrameRateCalculator
 	frameRateCalculated bool
+
+	packetNotFoundCount atomic.Uint32
+	packetTooOldCount   atomic.Uint32
 }
 
 // NewBuffer constructs a new Buffer
@@ -465,8 +469,13 @@ func (b *Buffer) calc(pkt []byte, arrivalTime time.Time) {
 	rtpPacket.Header.SequenceNumber = uint16(flowState.ExtSequenceNumber)
 	_, err = b.bucket.AddPacketWithSequenceNumber(pkt, rtpPacket.Header.SequenceNumber)
 	if err != nil {
-		if err != bucket.ErrRTXPacket {
-			b.logger.Warnw("could not add RTP packet to bucket", err)
+		if errors.Is(err, bucket.ErrPacketTooOld) {
+			packetTooOldCount := b.packetTooOldCount.Inc()
+			if packetTooOldCount%20 == 0 {
+				b.logger.Warnw("could not add packet to bucket", err, "count", packetTooOldCount)
+			}
+		} else if err != bucket.ErrRTXPacket {
+			b.logger.Warnw("could not add packet to bucket", err)
 		}
 		return
 	}
@@ -483,7 +492,10 @@ func (b *Buffer) calc(pkt []byte, arrivalTime time.Time) {
 func (b *Buffer) patchExtPacket(ep *ExtPacket, buf []byte) *ExtPacket {
 	n, err := b.getPacket(buf, ep.Packet.SequenceNumber)
 	if err != nil {
-		b.logger.Warnw("could not get packet", err, "sn", ep.Packet.SequenceNumber, "headSN", b.bucket.HeadSequenceNumber())
+		packetNotFoundCount := b.packetNotFoundCount.Inc()
+		if packetNotFoundCount%20 == 0 {
+			b.logger.Warnw("could not get packet from bucket", err, "sn", ep.Packet.SequenceNumber, "headSN", b.bucket.HeadSequenceNumber(), "count", packetNotFoundCount)
+		}
 		return nil
 	}
 	ep.RawPacket = buf[:n]