From b32933b0d4ba839ea38b702f94e6d7d4aeaadf26 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Thu, 14 May 2026 18:55:00 +0530 Subject: [PATCH] Log details of RTCP packets. (#4525) * Log details of RTCP packets. Seeing large (> MTU) packets on publisher peer connection RTCP. The four types there are - RTCP Receiver Reports - NACK - TWCC - PLI Can't think of what would be blowing up in size. RTCP Receiver Report and PLI are fixed in size NACKs vary, but the limit is 100 NACKs which should fit in 400 bytes even if all of them are spread apart in the sequence number space. TWCC varies, but a feedback packet is sent every 100ms or when it holds 100 packets. So, that also should not be too big. Logging packet details to understand this better. * revert debug --- pkg/rtc/transport.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/rtc/transport.go b/pkg/rtc/transport.go index 21a620f09..78a630c1b 100644 --- a/pkg/rtc/transport.go +++ b/pkg/rtc/transport.go @@ -1435,7 +1435,7 @@ func (t *PCTransport) WriteRTCP(pkts []rtcp.Packet) error { // TODO-CLEANUP-PACKET-SIZE: remove after checking for large packets raw, _ := rtcp.Marshal(pkts) if len(raw) > 1400 { - t.params.Logger.Infow("large RTCP packet send", "size", len(raw)) + t.params.Logger.Infow("large RTCP packet send", "size", len(raw), "numPkts", len(pkts), "pkts", pkts) } return t.pc.WriteRTCP(pkts) }