From baf47db8340cef1faed4d1b131254ddcbfe3ee66 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Thu, 28 Nov 2024 09:21:44 +0530 Subject: [PATCH] Publish data and signal bytes once every 30 seconds. (#3212) For applications with heavy data usage, accumulating data bytes over 5 minutes and then calculating rate using a much shorter window (like 2 - 5 seconds) makes it looks like there is a massive rate spike. While this change is not a fix, this should soften the impact. Need a better way to handle different parts of the system operating at different frequencies. Can use rate in the reporting window, but that will miss the spikes. Maybe that is okay. For example, if the reporting window is 5 minutes and there was a 100 Mbps spike for about 10 seconds of it, it would get smoothed out. --- pkg/telemetry/telemetryservice.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/telemetry/telemetryservice.go b/pkg/telemetry/telemetryservice.go index 1673ffe09..9d27c4be9 100644 --- a/pkg/telemetry/telemetryservice.go +++ b/pkg/telemetry/telemetryservice.go @@ -88,7 +88,7 @@ const ( jobsQueueMinSize = 2048 telemetryStatsUpdateInterval = time.Second * 30 - telemetryNonMediaStatsUpdateInterval = time.Minute * 5 + telemetryNonMediaStatsUpdateInterval = time.Second * 30 ) type telemetryService struct {