From bbbe815260f524730ae3766b82b88b2a7fc98b4b Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Tue, 23 May 2023 12:55:24 +0530 Subject: [PATCH] Init min to max MOS (#1734) * Init min to max MOS Could have been contributing to low p50 score in prom stats. * don't need to reset on no tracks as default is that --- pkg/rtc/participant.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/pkg/rtc/participant.go b/pkg/rtc/participant.go index 96db0b3d0..876f3c1d7 100644 --- a/pkg/rtc/participant.go +++ b/pkg/rtc/participant.go @@ -860,7 +860,7 @@ func (p *ParticipantImpl) GetAudioLevel() (level float64, active bool) { func (p *ParticipantImpl) GetConnectionQuality() *livekit.ConnectionQualityInfo { numTracks := 0 minQuality := livekit.ConnectionQuality_EXCELLENT - minScore := float32(0.0) + minScore := connectionquality.MaxMOS numUpDrops := 0 numDownDrops := 0 @@ -919,11 +919,6 @@ func (p *ParticipantImpl) GetConnectionQuality() *livekit.ConnectionQualityInfo availableTracks[trackID] = true } - if numTracks == 0 { - minQuality = livekit.ConnectionQuality_EXCELLENT - minScore = connectionquality.MaxMOS - } - prometheus.RecordQuality(minQuality, minScore, numUpDrops, numDownDrops) // remove unavailable tracks from track quality cache