From bd7950f56c04dc43238e8f96bae3df0e05b375ff Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Wed, 21 Feb 2024 20:21:59 +0530 Subject: [PATCH] Cleaning up logs added for debugging (#2497) --- pkg/rtc/mediatrack.go | 2 -- pkg/rtc/participant.go | 2 +- pkg/sfu/downtrack.go | 12 ------------ pkg/sfu/forwarder.go | 14 -------------- 4 files changed, 1 insertion(+), 29 deletions(-) diff --git a/pkg/rtc/mediatrack.go b/pkg/rtc/mediatrack.go index 16f6c24f3..57141fb62 100644 --- a/pkg/rtc/mediatrack.go +++ b/pkg/rtc/mediatrack.go @@ -257,11 +257,9 @@ func (t *MediaTrack) AddReceiver(receiver *webrtc.RTPReceiver, track *webrtc.Tra sfu.WithStreamTrackers(), ) newWR.OnCloseHandler(func() { - t.params.Logger.Infow("webrtc receiver closed") t.MediaTrackReceiver.SetClosing() t.MediaTrackReceiver.ClearReceiver(mime, false) if t.MediaTrackReceiver.TryClose() { - t.params.Logger.Infow("mediaTrack closed") if t.dynacastManager != nil { t.dynacastManager.Close() } diff --git a/pkg/rtc/participant.go b/pkg/rtc/participant.go index 74e27dc2f..a3b939955 100644 --- a/pkg/rtc/participant.go +++ b/pkg/rtc/participant.go @@ -2104,7 +2104,7 @@ func (p *ParticipantImpl) addMediaTrack(signalCid string, sdpCid string, ti *liv p.dirty.Store(true) - p.pubLogger.Infow("track unpublished", "trackID", ti.Sid, "track", logger.Proto(ti)) + p.pubLogger.Debugw("track unpublished", "trackID", ti.Sid, "track", logger.Proto(ti)) if onTrackUnpublished := p.getOnTrackUnpublished(); onTrackUnpublished != nil { onTrackUnpublished(p, mt) } diff --git a/pkg/sfu/downtrack.go b/pkg/sfu/downtrack.go index a4df99776..a4d0b1be5 100644 --- a/pkg/sfu/downtrack.go +++ b/pkg/sfu/downtrack.go @@ -1627,18 +1627,6 @@ func (d *DownTrack) retransmitPackets(nacks []uint16) { if err == io.EOF { break } - // TODO-VP9-DEBUG-REMOVE-START - d.params.Logger.Debugw( - "NACK miss", - "isn", epm.sourceSeqNo, - "osn", epm.targetSeqNo, - "ots", epm.timestamp, - "eosn", epm.extSequenceNumber, - "eots", epm.extTimestamp, - "sid", epm.layer, - "error", err, - ) - // TODO-VP9-DEBUG-REMOVE-END nackMisses++ continue } diff --git a/pkg/sfu/forwarder.go b/pkg/sfu/forwarder.go index 6d7c1d91a..fceebbdd6 100644 --- a/pkg/sfu/forwarder.go +++ b/pkg/sfu/forwarder.go @@ -1704,20 +1704,6 @@ func (f *Forwarder) getTranslationParamsVideo(extPkt *buffer.ExtPacket, layer in if tpRTP, err := f.rtpMunger.UpdateAndGetSnTs(extPkt, result.RTPMarker); err == nil { if tpRTP.snOrdering == SequenceNumberOrderingContiguous { f.rtpMunger.PacketDropped(extPkt) - } else { - // TODO-VP9-DEBUG-REMOVE-START - f.logger.Debugw( - "dropping packet skipped as not contiguous", - "isn", extPkt.ExtSequenceNumber, - "its", extPkt.ExtTimestamp, - "osn", tpRTP.extSequenceNumber, - "ots", tpRTP.extTimestamp, - "payloadLen", len(extPkt.Packet.Payload), - "sid", extPkt.Spatial, - "tid", extPkt.Temporal, - "snOrdering", tpRTP.snOrdering, - ) - // TODO-VP9-DEBUG-REMOVE-END } } }