From bdf01bbcef5701c326fb82cc605266c939c7cbef Mon Sep 17 00:00:00 2001 From: aoife cassidy Date: Fri, 16 Aug 2024 13:07:38 -0700 Subject: [PATCH] Remove check for rust on TrackSubscribed --- pkg/rtc/clientinfo.go | 8 ++------ pkg/rtc/participant_signal.go | 3 --- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/pkg/rtc/clientinfo.go b/pkg/rtc/clientinfo.go index 6312a0b91..54ed28cd5 100644 --- a/pkg/rtc/clientinfo.go +++ b/pkg/rtc/clientinfo.go @@ -92,13 +92,9 @@ func (c ClientInfo) ComplyWithCodecOrderInSDPAnswer() bool { return !((c.isLinux() || c.isAndroid()) && c.isFirefox()) } -// Rust SDK can't decode unknown signal message (TrackSubscribed and ErrorResponse) -func (c ClientInfo) SupportTrackSubscribedEvent() bool { - return !(c.ClientInfo.GetSdk() == livekit.ClientInfo_RUST && c.ClientInfo.GetProtocol() < 10) -} - +// Rust SDK can't decode unknown signal message (ErrorResponse) func (c ClientInfo) SupportErrorResponse() bool { - return c.SupportTrackSubscribedEvent() + return !(c.ClientInfo.GetSdk() == livekit.ClientInfo_RUST && c.ClientInfo.GetProtocol() < 10) } // compareVersion compares a semver against the current client SDK version diff --git a/pkg/rtc/participant_signal.go b/pkg/rtc/participant_signal.go index 6c4e61e2a..b08307084 100644 --- a/pkg/rtc/participant_signal.go +++ b/pkg/rtc/participant_signal.go @@ -313,9 +313,6 @@ func (p *ParticipantImpl) sendTrackUnpublished(trackID livekit.TrackID) { } func (p *ParticipantImpl) sendTrackHasBeenSubscribed(trackID livekit.TrackID) { - if !p.params.ClientInfo.SupportTrackSubscribedEvent() { - return - } _ = p.writeMessage(&livekit.SignalResponse{ Message: &livekit.SignalResponse_TrackSubscribed{ TrackSubscribed: &livekit.TrackSubscribed{