From c0ea1b9ced1973ff84f417088610d5fb35f3c6ed Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Wed, 16 Aug 2023 12:17:29 +0530 Subject: [PATCH] Remove warning for probe rate being too high. (#1970) Not super useful. It does happen a bunch of times especially at lower end of estimate where the next layer up is high. We have to probe anyway. Effects of large jumps have been mitigated by doing it for short time. --- pkg/sfu/streamallocator/streamallocator.go | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/pkg/sfu/streamallocator/streamallocator.go b/pkg/sfu/streamallocator/streamallocator.go index 4b0a61015..6441714b2 100644 --- a/pkg/sfu/streamallocator/streamallocator.go +++ b/pkg/sfu/streamallocator/streamallocator.go @@ -1212,20 +1212,6 @@ func (s *StreamAllocator) newChannelObserverNonProbe() *ChannelObserver { func (s *StreamAllocator) initProbe(probeGoalDeltaBps int64) { expectedBandwidthUsage := s.getExpectedBandwidthUsage() - if float64(expectedBandwidthUsage) > 1.5*float64(s.committedChannelCapacity) { - // STREAM-ALLOCATOR-TODO-START - // Should probably skip probing if the expected usage is much higher than committed channel capacity. - // But, give that bandwidth estimate is volatile at times and can drop down to small values, - // not probing means streaming stuck in a well for long. - // Observe this and figure out if there is a threshold from practical use cases that can be used to - // skip probing safely - // STREAM-ALLOCATOR-TODO-END - s.params.Logger.Warnw( - "stream allocator: starting probe alarm", - fmt.Errorf("expected too high, expected: %d, committed: %d", expectedBandwidthUsage, s.committedChannelCapacity), - ) - } - probeClusterId, probeGoalBps := s.probeController.InitProbe(probeGoalDeltaBps, expectedBandwidthUsage) channelState := ""