From ca77df8212997862199cfda60b9c8b39b211000f Mon Sep 17 00:00:00 2001 From: cnderrauber Date: Thu, 24 Oct 2024 16:59:24 +0800 Subject: [PATCH] warn for multiple dd ext (#3135) * warn for multiple dd ext * unused --- pkg/sfu/buffer/buffer.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/sfu/buffer/buffer.go b/pkg/sfu/buffer/buffer.go index ea9f30eec..e0cbe66aa 100644 --- a/pkg/sfu/buffer/buffer.go +++ b/pkg/sfu/buffer/buffer.go @@ -134,7 +134,6 @@ type Buffer struct { packetNotFoundCount atomic.Uint32 packetTooOldCount atomic.Uint32 extPacketTooMuchCount atomic.Uint32 - invalidPacketCount atomic.Uint32 primaryBufferForRTX *Buffer rtxPktBuf []byte @@ -231,6 +230,10 @@ func (b *Buffer) Bind(params webrtc.RTPParameters, codec webrtc.RTPCodecCapabili switch ext.URI { case dd.ExtensionURI: if IsSvcCodec(codec.MimeType) { + if b.ddExtID != 0 { + b.logger.Warnw("multiple dependency descriptor extensions found", nil, "id", ext.ID, "previous", b.ddExtID) + continue + } b.ddExtID = uint8(ext.ID) frc := NewFrameRateCalculatorDD(b.clockRate, b.logger) for i := range b.frameRateCalculator {