Misc/minor clean up. (#3183)

Cosmetic. While thinking through how to structure probing better,
noticing small things here and there. Cleaning up and making some small
PRs along the way.

pkg/sfu/streamallocator/probe_controller.go

@@ -120,15 +120,13 @@ func (p *ProbeController) Reset() {
 
 func (p *ProbeController) ProbeClusterDone(info ccutils.ProbeClusterInfo) {
 	p.lock.Lock()
+	defer p.lock.Unlock()
 
 	if p.probeClusterId != info.Id {
 		p.params.Logger.Debugw("not expected probe cluster", "probeClusterId", p.probeClusterId, "resetProbeClusterId", info.Id)
-		p.lock.Unlock()
-		return
+	} else {
+		p.doneProbeClusterInfo = info
 	}
-
-	p.doneProbeClusterInfo = info
-	p.lock.Unlock()
 }
 
 func (p *ProbeController) MaybeFinalizeProbe(

pkg/sfu/streamallocator/streamallocator.go

@@ -210,9 +210,6 @@ func NewStreamAllocator(params StreamAllocatorParams, enabled bool, allowPause b
 		params:     params,
 		enabled:    enabled,
 		allowPause: allowPause,
-		prober: ccutils.NewProber(ccutils.ProberParams{
-			Logger: params.Logger,
-		}),
 		// STREAM-ALLOCATOR-DATA rateMonitor: NewRateMonitor(),
 		videoTracks: make(map[livekit.TrackID]*Track),
 		eventsQueue: utils.NewTypedOpsQueue[Event](utils.OpsQueueParams{
@@ -222,6 +219,11 @@ func NewStreamAllocator(params StreamAllocatorParams, enabled bool, allowPause b
 		}),
 	}
 
+	s.prober = ccutils.NewProber(ccutils.ProberParams{
+		Listener: s,
+		Logger:   params.Logger,
+	})
+
 	s.probeController = NewProbeController(ProbeControllerParams{
 		Config: s.params.Config.ProbeController,
 		Prober: s.prober,
@@ -230,8 +232,6 @@ func NewStreamAllocator(params StreamAllocatorParams, enabled bool, allowPause b
 
 	s.resetState()
 
-	s.prober.SetProberListener(s)
-
 	return s
 }