From dbbf2f886f71ba82c04b0cb522eff5fde85a1408 Mon Sep 17 00:00:00 2001 From: Raja Subramanian Date: Wed, 2 Aug 2023 16:33:58 +0530 Subject: [PATCH] Skip video layer update if sub muted (#1929) Previous change to check for non-zero width caused test failures as subscribed track settings can use the quality field and not necessarily width/height. --- pkg/rtc/subscribedtrack.go | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/pkg/rtc/subscribedtrack.go b/pkg/rtc/subscribedtrack.go index 10bf25fcb..7d2e4f0b7 100644 --- a/pkg/rtc/subscribedtrack.go +++ b/pkg/rtc/subscribedtrack.go @@ -211,18 +211,15 @@ func (t *SubscribedTrack) UpdateVideoLayer() { } settings := t.settings.Load() - if settings == nil { + if settings == nil || settings.Disabled { return } t.logger.Debugw("updating video layer", "settings", settings) - - if settings.Width > 0 || settings.Fps > 0 { - spatial := t.spatialLayerFromSettings(settings) - t.DownTrack().SetMaxSpatialLayer(spatial) - if settings.Fps > 0 { - t.DownTrack().SetMaxTemporalLayer(t.MediaTrack().GetTemporalLayerForSpatialFps(spatial, settings.Fps, t.DownTrack().Codec().MimeType)) - } + spatial := t.spatialLayerFromSettings(settings) + t.DownTrack().SetMaxSpatialLayer(spatial) + if settings.Fps > 0 { + t.DownTrack().SetMaxTemporalLayer(t.MediaTrack().GetTemporalLayerForSpatialFps(spatial, settings.Fps, t.DownTrack().Codec().MimeType)) } }